Skip to content

fix(ui): remove redundant back button in selection-view#2119

Merged
graphieros merged 2 commits intonpmx-dev:mainfrom
MatteoGabriele:fix/remove-redundant-back-button
Mar 17, 2026
Merged

fix(ui): remove redundant back button in selection-view#2119
graphieros merged 2 commits intonpmx-dev:mainfrom
MatteoGabriele:fix/remove-redundant-back-button

Conversation

@MatteoGabriele
Copy link
Member

🧭 Context

The search page's selection view has two back buttons, likely caused by a merge conflict issue.

📚 Description

Removes extra back button in the view

Screenshot 2026-03-17 at 15 15 50

@vercel
Copy link

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 17, 2026 2:24pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 17, 2026 2:24pm
npmx-lunaria Ignored Ignored Mar 17, 2026 2:24pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 76382ebb-be74-4b0b-b724-1963aa36b1a6

📥 Commits

Reviewing files that changed from the base of the PR and between 3fc9ebd and 0393a0c.

📒 Files selected for processing (1)
  • app/components/Package/SelectionView.vue

📝 Walkthrough

Walkthrough

The pull request modifies the SelectionView component by removing the back navigation button and its associated UI elements from the header. The header layout alignment changes from justify-between to justify-end, with only the action group containing Clear All and Compare links remaining on the right side. The closeSelectionView trigger mechanism is removed alongside the back button UI. Public entity exports remain unchanged, with a net change of one line added and ten lines removed.

Suggested reviewers

  • serhalp
  • alexdln
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the removal of a redundant back button caused by a merge conflict.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌿

@graphieros graphieros added this pull request to the merge queue Mar 17, 2026
Merged via the queue into npmx-dev:main with commit a0e8534 Mar 17, 2026
20 checks passed
@github-actions github-actions bot mentioned this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants