Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions shared/utils/package-analysis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,17 +200,21 @@ export function getCreatePackageName(packageName: string): string {

/**
* Extract the short name from a create-* package for display.
* e.g., "create-vite" -> "vite", "@scope/create-foo" -> "foo"
* e.g., "create-vite" -> "vite", "@scope/create-foo" -> "@scope/foo", "@scope/create" -> "@scope"
*/
export function getCreateShortName(createPackageName: string): string {
if (createPackageName.startsWith('@')) {
// @scope/create-foo -> foo
// @scope/create -> @scope, @scope/create-foo -> @scope/foo
const slashIndex = createPackageName.indexOf('/')
const scope = createPackageName.slice(0, slashIndex)
const name = createPackageName.slice(slashIndex + 1)
if (name === 'create') {
return scope
}
if (name.startsWith('create-')) {
return name.slice('create-'.length)
return `${scope}/${name.slice('create-'.length)}`
}
return name
return createPackageName
}
// create-vite -> vite
if (createPackageName.startsWith('create-')) {
Expand Down
12 changes: 11 additions & 1 deletion test/unit/app/utils/install-command.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,17 @@ describe('install command generation', () => {
packageManager: 'npm',
isCreatePackage: true,
}),
).toEqual(['npm', 'create', 'app'])
).toEqual(['npm', 'create', '@vue/app'])
})

it('handles @scope/create pattern', () => {
expect(
getExecuteCommandParts({
packageName: '@angular/create',
packageManager: 'npm',
isCreatePackage: true,
}),
).toEqual(['npm', 'create', '@angular'])
})
})
})
Expand Down
12 changes: 8 additions & 4 deletions test/unit/shared/utils/package-analysis.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -429,19 +429,23 @@ describe('getCreateShortName', () => {
expect(getCreateShortName('create-vite')).toBe('vite')
})

it('extracts name from scoped create-* package', () => {
expect(getCreateShortName('@vue/create-app')).toBe('app')
it('extracts name from scoped create-* package preserving scope', () => {
expect(getCreateShortName('@vue/create-app')).toBe('@vue/app')
})

it('returns full name if not a create-* package', () => {
expect(getCreateShortName('vite')).toBe('vite')
})

it('handles scoped package without create- prefix', () => {
expect(getCreateShortName('@scope/foo')).toBe('foo')
it('returns full name for scoped package without create- prefix', () => {
expect(getCreateShortName('@scope/foo')).toBe('@scope/foo')
})

it('extracts name from create-next-app style packages', () => {
expect(getCreateShortName('create-next-app')).toBe('next-app')
})

it('returns scope only for @scope/create packages', () => {
expect(getCreateShortName('@angular/create')).toBe('@angular')
})
})
Loading