fix: create packages being broken for scoped packages#2079
fix: create packages being broken for scoped packages#2079serhalp merged 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe changes modify the Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
🧭 Context
I noticed a couple of bugs on the create package suggestions and wondered what the root cause was. This was it. According to the npm docs (https://docs.npmjs.com/cli/v11/commands/npm-init),
@scope/create-packageshould be called withnpm create @scope/package. Code existed that handled that case, but it was... wrong? Idk how that happened. I also noticed we didn't handle@scope/createcorrectly either so I fixed both and added tests.