Skip to content

fix: fix more svg icons#1858

Merged
serhalp merged 1 commit intonpmx-dev:mainfrom
cscnk52:fix/icons
Mar 3, 2026
Merged

fix: fix more svg icons#1858
serhalp merged 1 commit intonpmx-dev:mainfrom
cscnk52:fix/icons

Conversation

@cscnk52
Copy link
Copy Markdown
Contributor

@cscnk52 cscnk52 commented Mar 3, 2026

🔗 Linked issue

🧭 Context

Same as #1734 fix more.

📚 Description

before:

image

after:

image

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 3, 2026 2:16am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 3, 2026 2:16am
npmx-lunaria Ignored Ignored Mar 3, 2026 2:16am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c29857 and f4011d9.

📒 Files selected for processing (2)
  • app/components/Code/DirectoryListing.vue
  • app/components/Code/FileTree.vue
💤 Files with no reviewable changes (2)
  • app/components/Code/FileTree.vue
  • app/components/Code/DirectoryListing.vue

📝 Walkthrough

Walkthrough

The pull request removes fill="currentColor" attributes from SVG elements across two Vue components. Specifically, two SVG elements in DirectoryListing.vue and one SVG element in FileTree.vue are modified by removing the fill attribute. The changes are presentation-only and do not affect control flow, data handling, or error management.

Possibly related PRs

  • PR #1734: Removes fill="currentColor" attributes from SVG elements to prevent external CSS from affecting icon rendering, with direct overlap in FileTree.vue changes.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description references issue #1734 and includes before/after images showing visual changes to SVG icons, which aligns with the changeset that removes fill attributes from SVG elements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@serhalp serhalp added this pull request to the merge queue Mar 3, 2026
Merged via the queue into npmx-dev:main with commit 112f6e2 Mar 3, 2026
21 checks passed
@cscnk52 cscnk52 deleted the fix/icons branch March 3, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants