Skip to content

fix: prevent external CSS from affecting SVG icons#1734

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
cscnk52:fix/icon
Feb 28, 2026
Merged

fix: prevent external CSS from affecting SVG icons#1734
danielroe merged 1 commit intonpmx-dev:mainfrom
cscnk52:fix/icon

Conversation

@cscnk52
Copy link
Copy Markdown
Contributor

@cscnk52 cscnk52 commented Feb 28, 2026

🔗 Linked issue

🧭 Context

📚 Description

Remove fill, prevent external CSS affect icon.

Before:
image

After:

image

The LICENSE icon was missing because vscode-icons-theme uses a linearGradient in the icon, which is not valid inside Shadow DOM.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 28, 2026 3:59am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 28, 2026 3:59am
npmx-lunaria Ignored Ignored Feb 28, 2026 3:59am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 671d13a and ea0cf18.

📒 Files selected for processing (1)
  • app/components/Code/FileTree.vue

📝 Walkthrough

Walkthrough

The pull request modifies SVG icon markup in the FileTree.vue component. Two inline SVGs have their fill="currentColor" attribute removed—one in the directory header and one in the file section. The opening tags for both SVGs are collapsed into single-line formatting. The SVGs retain their class, viewBox, and aria-hidden attributes. The change reduces the total line count by five lines.

Possibly related PRs

Suggested reviewers

  • danielroe
  • carwack
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the removal of the fill attribute from SVG icons in FileTree.vue to prevent external CSS from affecting them.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 28, 2026
Merged via the queue into npmx-dev:main with commit 3ac5eca Feb 28, 2026
18 checks passed
@github-actions
Copy link
Copy Markdown

Thanks for your first contribution, @cscnk52! 🙌

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

@cscnk52 cscnk52 deleted the fix/icon branch February 28, 2026 07:57
@cscnk52 cscnk52 mentioned this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants