Skip to content

chore: tests should not inherit --ignore-scripts flag from `npm run t… #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

chore: tests should not inherit --ignore-scripts flag from `npm run t… #422

merged 1 commit into from
Apr 15, 2025

Conversation

@owlstronaut
Copy link
Contributor

@owlstronaut owlstronaut commented Apr 14, 2025 •
edited
Loading

CI is currently failing in main. This aims to resolve it. It was tricky to figure out the difference because I don't usually run npm test with --ignore-scripts locally.

@owlstronaut
chore: tests should not inherit --ignore-scripts flag from `npm run t…
5534645 
…ests`

    # Subtest: running bin runs main file
        ok 1 - should be equal
        ok 2 - should be equal
        ok 3 - helpful output
        1..3
    ok 1 - running bin runs main file # time=171.725ms

    # Subtest: parseArg
        ok 1 - should be equivalent
        ok 2 - should be equivalent
        ok 3 - should be equivalent
        ok 4 - should be equivalent
        ok 5 - should be equivalent
        1..5
    ok 2 - parseArg # time=2.784ms

    # Subtest: parse
        ok 1 - should be equivalent
        ok 2 - should be equivalent
        ok 3 - should be equivalent
        ok 4 - should match pattern provided
        1..4
    ok 3 - parse # time=1.184ms

    # Subtest: run
        ok 1 - expect resolving Promise
        ok 2 - expect resolving Promise
        ok 3 - expect resolving Promise
        ok 4 - expect resolving Promise
        ok 5 - expect resolving Promise
        ok 6 - expected to throw
        ok 7 - expect resolving Promise
        ok 8 - should be equal
        1..8
    ok 4 - run # time=8.484ms

    # Subtest: main
        # Subtest: --help
            ok 1 - must match snapshot
            1..1
        ok 1 - --help # time=5.577ms

        # Subtest: resolve foo@bar
            ok 1 - must match snapshot
            1..1
        ok 2 - resolve foo@bar # time=0.411ms

        # Subtest: resolve foo@bar --long
            ok 1 - must match snapshot
            1..1
        ok 3 - resolve foo@bar --long # time=0.278ms

        # Subtest: resolve string
            ok 1 - must match snapshot
            1..1
        ok 4 - resolve string # time=0.22ms

        # Subtest: resolve string --json
            ok 1 - must match snapshot
            1..1
        ok 5 - resolve string --json # time=0.146ms

        # Subtest: manifest bar@foo
            ok 1 - must match snapshot
            1..1
        ok 6 - manifest bar@foo # time=0.232ms

        # Subtest: packument paku@mint
            ok 1 - must match snapshot
            1..1
        ok 7 - packument paku@mint # time=0.143ms

        # Subtest: tarball tar@ball file.tgz
            ok 1 - must match snapshot
            1..1
        ok 8 - tarball tar@ball file.tgz # time=0.158ms

        # Subtest: extract npm@latest-6 folder --no-json
            ok 1 - must match snapshot
            1..1
        ok 9 - extract npm@latest-6 folder --no-json # time=0.212ms

        # Subtest: extract npm@latest-6 folder --json
            ok 1 - must match snapshot
            1..1
        ok 10 - extract npm@latest-6 folder --json # time=0.187ms

        # Subtest: blerg glorb glork
            ok 1 - must match snapshot
            1..1
        ok 11 - blerg glorb glork # time=0.257ms

        # Subtest: resolve fail
            ok 1 - must match snapshot
            1..1
        ok 12 - resolve fail # time=0.208ms

        1..12
    ok 5 - main # time=9.973ms

    1..5
    # time=195.878ms
ok 1 - test/bin.js # time=195.878ms

    # Subtest: basic
        ok 1 - should be equivalent
        ok 2 - packument
        ok 3 - manifest
        ok 4 - extract
        ok 5 - package.json extracted
        ok 6 - saved package.json
        ok 7 - should be equal
        1..7
    ok 1 - basic # time=57.264ms

    # Subtest: dir with integrity
        ok 1 - should be equivalent
        ok 2 - packument
        1..2
    ok 2 - dir with integrity # time=2.597ms

    # Subtest: with prepare script
        ok 1 - packument
        ok 2 - manifest
        ok 3 - extract
        # Subtest: test prepared result
            1..1
            ok 1 - no dev dep
        ok 4 - test prepared result # time=93.846ms

        ok 5 - file list
        ok 6 - should run in background
        1..6
    ok 3 - with prepare script # time=313.857ms

    # Subtest: with prepare script with scriptshell configuration
        ok 1 - packument
        ok 2 - manifest
        ok 3 - extract
        # Subtest: test prepared result
            1..1
            ok 1 - no dev dep
        ok 4 - test prepared result # time=68.602ms

        ok 5 - file list
        ok 6 - should run in background and use scriptshell configuration
        1..6
    ok 4 - with prepare script with scriptshell configuration # time=245.362ms

    # Subtest: responds to foregroundScripts: true
        ok 1 - packument
        ok 2 - manifest
        ok 3 - extract
        # Subtest: test prepared result
            1..1
            ok 1 - no dev dep
        ok 4 - test prepared result # time=60.766ms

        ok 5 - file list
        ok 6 - should run in foreground
        1..6
    ok 5 - responds to foregroundScripts: true # time=256.765ms

    # Subtest: missing dir cannot be packed
        ok 1 - expect rejected Promise
        1..1
    ok 6 - missing dir cannot be packed # time=101.002ms

    # Subtest: when read fails
        ok 1 - expect rejected Promise: Error poop
        1..1
    ok 7 - when read fails # time=304.308ms

    # Subtest: make bins executable
        ok 1 - results of unpack
        ok 2 - should be equal
        1..2
    ok 8 - make bins executable # time=20.35ms

    # Subtest: exposes tarCreateOptions method
        ok 1 - should return standard options
        1..1
    ok 9 - exposes tarCreateOptions method # time=1.102ms

    # Subtest: fails without a tree or constructor
        ok 1 - expect rejected Promise
        1..1
    ok 10 - fails without a tree or constructor # time=1.441ms

    # Subtest: with prepare script and ignoreScripts true
        ok 1 - expect truthy value
        1..1
    ok 11 - with prepare script and ignoreScripts true # time=13.197ms

    1..11
    # time=1320.669ms
ok 2 - test/dir.js # time=1320.669ms

    # Subtest: do not mutate opts object passed in
        ok 1 - should be equivalent strictly
        ok 2 - should match pattern provided
        1..2
    ok 1 - do not mutate opts object passed in # time=3.891ms

    # Subtest: snapshot the npmInstallCmd and npmInstallConfig
        ok 1 - use default npm bin
        ok 2 - default install cmd
        ok 3 - default install config
        ok 4 - do not have a _cacache folder on cache config passed to npm cli
        ok 5 - have a _cacache folder on default pacote config itself
        ok 6 - use default npm bin
        ok 7 - default install cmd with before
        ok 8 - default install config with before
        ok 9 - use default yarn bin
        ok 10 - customized npmInstallCmd
        ok 11 - yarn style cli config stuff
        1..11
    ok 2 - snapshot the npmInstallCmd and npmInstallConfig # time=8.938ms

    # Subtest: tarball data
        ok 1 - without integrity
        ok 2 - integrity calculated
        ok 3 - with integrity
        1..3
    ok 3 - tarball data # time=23.38ms

    # Subtest: tarballFile
        # Subtest: basic
            ok 1 - 1.tgz
            ok 2 - 2.tgz
            1..2
        ok 1 - basic # time=17.902ms

        # Subtest: fs read stream error
            ok 1 - tarballFile
            ok 2 - tarball stream
            1..2
        ok 2 - fs read stream error # time=3.8ms

        # Subtest: fs write stream error
            ok 1 - expect rejected Promise
            1..1
        ok 3 - fs write stream error # time=6.91ms

        # Subtest: file not found
            ok 1 - expect rejected Promise
            1..1
        ok 4 - file not found # time=2.742ms

        1..4
    ok 4 - tarballFile # time=32.851ms

    # Subtest: extract
        # Subtest: uncached
            ok 1 - resolved to filename
            ok 2 - integrity match
            ok 3 - name in package.json
            ok 4 - version in package.json
            1..4
        ok 1 - uncached # time=0.565ms

        # Subtest: cached
            ok 1 - resolved to filename
            ok 2 - integrity match
            ok 3 - name in package.json
            ok 4 - version in package.json
            1..4
        ok 2 - cached # time=0.484ms

        ok 3 - got expected logs
        # Subtest: badcache
            ok 1 - resolved to filename
            ok 2 - integrity match
            ok 3 - name in package.json
            ok 4 - version in package.json
            1..4
        ok 4 - badcache # time=0.357ms

        ok 5 - expect rejected Promise
        ok 6 - expect rejected Promise
        ok 7 - got expected error
        ok 8 - got expected logs
        1..8
    ok 5 - extract # time=94.131ms

    # Subtest: extract into folder that already has a package in it
        ok 1 - excluded or removedindex-hardlink.js
        ok 2 - excluded or removedindex-symlink.js
        ok 3 - excluded or removed.gitignore
        ok 4 - excluded or removedlib/.gitignore
        ok 5 - excluded or removedno-gitignore-here/.gitignore
        ok 6 - excluded or removednode_modules/foo
        ok 7 - excluded or removednode_modules/.bin/foo
        ok 8 - still have file at no-gitignore-here/.npmignore
        ok 9 - still have file at node_modules/bar/package.json
        ok 10 - still have file at node_modules/bar/index.js
        ok 11 - still have file at node_modules/.bin/bar
        1..11
    ok 6 - extract into folder that already has a package in it # time=32.087ms

    # Subtest: a non-retriable cache error
        ok 1 - expect rejected Promise: Error poop
        1..1
    ok 7 - a non-retriable cache error # time=6.842ms

    # Subtest: before implies full metadata
        ok 1 - should be equal
        1..1
    ok 8 - before implies full metadata # time=1.287ms

    # Subtest: various projectiles
        ok 1 - expected to throw
        ok 2 - expect rejected Promise
        ok 3 - has resolved
        ok 4 - expect rejected Promise
        ok 5 - expect rejected Promise
        ok 6 - expect rejected Promise
        ok 7 - expect rejected Promise
        ok 8 - expected to throw
        ok 9 - expected to throw
        1..9
    ok 9 - various projectiles # time=2.204ms

    # Subtest: fetcher.get
        ok 1 - should be equal
        ok 2 - should be equal
        ok 3 - should be equal
        ok 4 - should be equal
        ok 5 - should be equal
        ok 6 - should be equal
        ok 7 - should be equal
        ok 8 - should be equal
        ok 9 - should be equal
        ok 10 - should be equal
        ok 11 - should be equal
        ok 12 - should be equal
        ok 13 - should be equal
        1..13
    ok 10 - fetcher.get # time=2.249ms

    # Subtest: make bins executable
        ok 1 - should be equal
        ok 2 - results of unpack
        ok 3 - should be equal
        1..3
    ok 11 - make bins executable # time=8.756ms

    # Subtest: set integrity, pick default algo
        ok 1 - should be equal
        ok 2 - type is Object
        ok 3 - cannot remove integrity
        ok 4 - should be equal
        1..4
    ok 12 - set integrity, pick default algo # time=0.436ms

    # Subtest: replace opts defaults to default registry
        ok 1 - should be equal
        1..1
    ok 13 - replace opts defaults to default registry # time=0.097ms

    # Subtest: replace opts never
        ok 1 - should be equal
        1..1
    ok 14 - replace opts never # time=0.107ms

    # Subtest: replace opts always
        ok 1 - should be equal
        1..1
    ok 15 - replace opts always # time=0.093ms

    1..15
    # time=228.907ms
ok 3 - test/fetcher.js # time=228.907ms

    # Subtest: basic
        ok 1 - should be equivalent
        ok 2 - manifest
        ok 3 - should be equal
        ok 4 - cached manifest
        ok 5 - packument
        ok 6 - extract
        ok 7 - package.json extracted
        ok 8 - write cache content file
        1..8
    ok 1 - basic # time=47.731ms

    # Subtest: make bins executable
        1..3
        # Subtest: bin-string
            ok 1 - results of unpack
            ok 2 - should be equal
            1..2
        ok 1 - bin-string # time=10.08ms

        # Subtest: bin-object
            ok 1 - results of unpack
            ok 2 - should be equal
            1..2
        ok 2 - bin-object # time=4.829ms

        # Subtest: bin-good
            ok 1 - results of unpack
            ok 2 - should be equal
            1..2
        ok 3 - bin-good # time=5.188ms

    ok 2 - make bins executable # time=21.632ms

    # Subtest: dont bork on missing script
        ok 1 - should be missing
        1..1
    ok 3 - dont bork on missing script # time=6.812ms

    # Subtest: with readme
        ok 1 - should be equivalent
        ok 2 - manifest-slow-json
        ok 3 - should be equal
        ok 4 - cached manifest
        ok 5 - packument-slow-json
        ok 6 - extract-slow-json
        ok 7 - package.json extracted slow json
        ok 8 - write cache content file
        1..8
    ok 4 - with readme # time=68.788ms

    1..4
    # time=146.811ms
ok 4 - test/file.js # time=146.811ms

    ok 1 - resolve
    ok 2 - extract
    ok 3 - manifest
    ok 4 - packument
    ok 5 - tarball
    ok 6 - tarball to file
    ok 7 - manifest
    ok 8 - should expose fetcher classes
    ok 9 - should expose fetcher classes
    ok 10 - should expose fetcher classes
    ok 11 - should expose fetcher classes
    ok 12 - should expose fetcher classes
    ok 13 - should match pattern provided
    ok 14 - should match pattern provided
    1..14
    # time=50.759ms
ok 5 - test/index.js # time=50.759ms

    # Subtest: underscore, no tag or version
        ok 1 - should be equal
        ok 2 - should be equal
        ok 3 - should match pattern provided
        ok 4 - manifest cached
        ok 5 - should be equivalent
        1..5
    ok 1 - underscore, no tag or version # time=129.758ms

    # Subtest: scoped, no tag or version
        ok 1 - should be equal
        ok 2 - should match pattern provided
        ok 3 - should be equivalent
        1..3
    ok 2 - scoped, no tag or version # time=14.685ms

    # Subtest: provide invalid integrity, fails to unpack
        ok 1 - expect rejected Promise
        1..1
    ok 3 - provide invalid integrity, fails to unpack # time=8.553ms

    # Subtest: provide invalid integrity, fails to manifest
        ok 1 - expect rejected Promise
        1..1
    ok 4 - provide invalid integrity, fails to manifest # time=9.122ms

    # Subtest: provide different type of integrity, concats
        ok 1 - should be equal
        1..1
    ok 5 - provide different type of integrity, concats # time=9.761ms

    # Subtest: provide matching integrity, totes ok, includes signature
        ok 1 - should match pattern provided
        1..1
    ok 6 - provide matching integrity, totes ok, includes signature # time=11.516ms

    # Subtest: verifySignatures valid signature
        ok 1 - expect truthy value
        ok 2 - expect truthy value
        1..2
    ok 7 - verifySignatures valid signature # time=11.753ms

    # Subtest: verifySignatures expired key
        ok 1 - expect rejected Promise
        1..1
    ok 8 - verifySignatures expired key # time=10.337ms

    # Subtest: verifySignatures rotated keys
        ok 1 - should match pattern provided
        1..1
    ok 9 - verifySignatures rotated keys # time=8.422ms

    # Subtest: verifySignatures invalid signature
        ok 1 - expect rejected Promise
        1..1
    ok 10 - verifySignatures invalid signature # time=7.439ms

    # Subtest: verifySignatures no valid key
        ok 1 - expect rejected Promise
        1..1
    ok 11 - verifySignatures no valid key # time=7.109ms

    # Subtest: verifySignatures no registry keys at all
        ok 1 - expect rejected Promise
        1..1
    ok 12 - verifySignatures no registry keys at all # time=9.914ms

    # Subtest: verifyAttestations valid attestations
        ok 1 - expect truthy value
        ok 2 - expect truthy value
        1..2
    ok 13 - verifyAttestations valid attestations # time=13.389ms

    # Subtest: verifyAttestations when registry returns no attestations
        ok 1 - expect rejected Promise
        1..1
    ok 14 - verifyAttestations when registry returns no attestations # time=10.163ms

    # Subtest: verifyAttestations when package has no attestations
        ok 1 - expect truthy value
        1..1
    ok 15 - verifyAttestations when package has no attestations # time=6.208ms

    # Subtest: disable verifyAttestations when package has attestations
        ok 1 - expect truthy value
        ok 2 - expect truthy value
        1..2
    ok 16 - disable verifyAttestations when package has attestations # time=14.522ms

    # Subtest: verifyAttestations invalid signature
        ok 1 - expect rejected Promise
        1..1
    ok 17 - verifyAttestations invalid signature # time=18.074ms

    # Subtest: verifyAttestations publish attestation for unknown public key
        ok 1 - expect rejected Promise
        1..1
    ok 18 - verifyAttestations publish attestation for unknown public key # time=16.56ms

    # Subtest: verifyAttestations no attestation with keyid
        ok 1 - expect rejected Promise
        1..1
    ok 19 - verifyAttestations no attestation with keyid # time=14.381ms

    # Subtest: verifyAttestations valid attestations
        ok 1 - expect rejected Promise
        1..1
    ok 20 - verifyAttestations valid attestations # time=13.378ms

    # Subtest: verifyAttestations no matching registry keys
        ok 1 - expect rejected Promise
        1..1
    ok 21 - verifyAttestations no matching registry keys # time=14.403ms

    # Subtest: verifyAttestations no valid key
        ok 1 - expect rejected Promise
        1..1
    ok 22 - verifyAttestations no valid key # time=10.939ms

    # Subtest: verifyAttestations rotated key
        ok 1 - expect truthy value
        ok 2 - expect truthy value
        1..2
    ok 23 - verifyAttestations rotated key # time=8.757ms

    # Subtest: verifyAttestations no registry keys at all
        ok 1 - expect rejected Promise
        1..1
    ok 24 - verifyAttestations no registry keys at all # time=10.002ms

    # Subtest: verifyAttestations fetching without version
        ok 1 - expect rejected Promise
        1..1
    ok 25 - verifyAttestations fetching without version # time=16.651ms

    # Subtest: verifyAttestations mismatched subject name
        ok 1 - expect rejected Promise
        1..1
    ok 26 - verifyAttestations mismatched subject name # time=30.804ms

    # Subtest: verifyAttestations mismatched subject sha512 digest
        ok 1 - expect rejected Promise
        1..1
    ok 27 - verifyAttestations mismatched subject sha512 digest # time=37.025ms

    # Subtest: verifyAttestations bundle payload that does not match the tlog entry
        ok 1 - expect rejected Promise
        1..1
    ok 28 - verifyAttestations bundle payload that does not match the tlog entry # time=16.363ms

    # Subtest: 404 fails with E404
        ok 1 - expect rejected Promise
        ok 2 - tried again with got full metadata
        1..2
    ok 29 - 404 fails with E404 # time=2.903ms

    # Subtest: respect default tag
        ok 1 - should be equal
        1..1
    ok 30 - respect default tag # time=5.459ms

    # Subtest: fail resolution if no dist.tarball
        ok 1 - expect rejected Promise
        1..1
    ok 31 - fail resolution if no dist.tarball # time=3.857ms

    # Subtest: a manifest that lacks integrity
        ok 1 - should have no integrity
        ok 2 - calculated integrity anyway
        ok 3 - serve cached packument
        1..3
    ok 32 - a manifest that lacks integrity # time=10.115ms

    # Subtest: packument that has been cached
        ok 1 - got cached packument
        1..1
    ok 33 - packument that has been cached # time=0.254ms

    # Subtest: corgi packument is not cached as full packument
        ok 1 - did not get cached packument
        ok 2 - full packument is also now cached
        1..2
    ok 34 - corgi packument is not cached as full packument # time=5.653ms

    # Subtest: packument that falls back to fullMetadata
        ok 1 - got packument (eventually)
        ok 2 - sent a 404 for the missing corgi doc
        1..2
    ok 35 - packument that falls back to fullMetadata # time=4.444ms

    # Subtest: option replaceRegistryHost
        # Subtest: host should not be replaced
            ok 1 - should be equal
            ok 2 - should be equal
            ok 3 - Underscores are preserved
            ok 4 - should match pattern provided
            1..4
        ok 1 - host should not be replaced # time=54.925ms

        # Subtest: host should be replaced
            ok 1 - should be equal
            ok 2 - should be equal
            ok 3 - should match pattern provided
            1..3
        ok 2 - host should be replaced # time=28.012ms

        # Subtest: host should be replaced if set to npmjs
            ok 1 - should be equal
            ok 2 - should be equal
            ok 3 - should match pattern provided
            1..3
        ok 3 - host should be replaced if set to npmjs # time=35.608ms

        1..3
    ok 36 - option replaceRegistryHost # time=120.145ms

    # Subtest: packument contentLength from registry
        ok 1 - content length is undefined from registry requests
        1..1
    ok 37 - packument contentLength from registry # time=5.011ms

    1..37
    # time=676.186ms
ok 6 - test/registry.js # time=676.186ms

    # Subtest: start server
        1..0
    ok 1 - start server # time=5.628ms

    # Subtest: packument
        ok 1 - packument
        ok 2 - packument 2
        ok 3 - only one request hit the server
        ok 4 - should match pattern provided
        1..4
    ok 2 - packument # time=67.616ms

    # Subtest: bad integrity
        ok 1 - expect rejected Promise
        1..1
    ok 3 - bad integrity # time=29.139ms

    # Subtest: known integrity
        ok 1 - got the right integrity back out
        1..1
    ok 4 - known integrity # time=3.582ms

    # Subtest: an missing tarball
        ok 1 - expect rejected Promise
        1..1
    ok 5 - an missing tarball # time=7.838ms

    # Subtest: not a tarball
        ok 1 - expect rejected Promise
        1..1
    ok 6 - not a tarball # time=34.164ms

    # Subtest: get a timeout error from the http fetch
        ok 1 - expect rejected Promise
        1..1
    ok 7 - get a timeout error from the http fetch # time=4.045ms

    # Subtest: option replaceRegistryHost
        # Subtest: host should be replaced if set to always on npmjs registry
            ok 1 - should be equal
            ok 2 - should match pattern provided
            1..2
        ok 1 - host should be replaced if set to always on npmjs registry # time=39.11ms

        # Subtest: host should be replaced if set to always on other registry
            ok 1 - should be equal
            ok 2 - should match pattern provided
            1..2
        ok 2 - host should be replaced if set to always on other registry # time=11.023ms

        1..2
    ok 8 - option replaceRegistryHost # time=60.368ms

    1..8
    # time=215.889ms
ok 7 - test/remote.js # time=215.889ms

    # Subtest: setup
        # Subtest: create repo
            1..0
        ok 1 - create repo # time=863.684ms

        # Subtest: create cycle of git prepared deps
            1..0
        ok 2 - create cycle of git prepared deps # time=1004.525ms

        # Subtest: spawn daemon
            1..0
        ok 3 - spawn daemon # time=86.94ms

        # Subtest: create a repo with a submodule
            1..0
        ok 4 - create a repo with a submodule # time=686.7ms

        # Subtest: create a repo with workspaces
            1..0
        ok 5 - create a repo with workspaces # time=165.045ms

        # Subtest: create a repo with only a prepack script
            1..0
        ok 6 - create a repo with only a prepack script # time=105.74ms

        # Subtest: hosted service
            1..0
        ok 7 - hosted service # time=0.82ms

        1..7
    ok 1 - setup # time=2917.891ms

    # Subtest: basic stuff
        ok 1 - should be equivalent
        ok 2 - should be equal
        ok 3 - should be equal
        ok 4 - should be equal
        ok 5 - should be equal
        ok 6 - should not be equal
        ok 7 - got the same resolved
        ok 8 - got the same integrity
        ok 9 - expected to throw
        ok 10 - should be equal
        ok 11 - should match pattern provided
        ok 12 - cached manifest
        1..12
    ok 2 - basic stuff # time=2288.335ms

    # Subtest: ignores integrity for git deps
        1..3
        ok 1 - should be equal
        ok 2 - should match pattern provided
        ok 3 - should match pattern provided
    ok 3 - ignores integrity for git deps # time=125.188ms

    # Subtest: weird hosted that doesnt provide any fetch targets
        ok 1 - expect rejected Promise
        ok 2 - expect rejected Promise
        1..2
    ok 4 - weird hosted that doesnt provide any fetch targets # time=1.945ms

    # Subtest: extract from tarball from hosted git service
        # Subtest: localhost
            # Subtest: with repo@ on the spec
                ok 1 - should match pattern provided
                ok 2 - should match pattern provided
                ok 3 - expected to throw
                1..3
            ok 1 - with repo@ on the spec # time=760.597ms

            # Subtest: without repo@on the spec
                ok 1 - should match pattern provided
                ok 2 - should match pattern provided
                ok 3 - expected to throw
                1..3
            ok 2 - without repo@on the spec # time=815.312ms

            1..2
        ok 1 - localhost # time=1577.022ms

        # Subtest: localhostssh
            # Subtest: with repo@ on the spec
                ok 1 - should match pattern provided
                ok 2 - should match pattern provided
                ok 3 - expected to throw
                1..3
            ok 1 - with repo@ on the spec # time=810.108ms

            # Subtest: without repo@on the spec
                ok 1 - should match pattern provided
                ok 2 - should match pattern provided
                ok 3 - expected to throw
                1..3
            ok 2 - without repo@on the spec # time=836.489ms

            1..2
        ok 2 - localhostssh # time=1647.569ms

        1..2
    ok 5 - extract from tarball from hosted git service # time=3225.716ms

    # Subtest: include auth with hosted https when provided
        ok 1 - should be equal
        ok 2 - using the correct dummy hosted service
        # Subtest: fail, but do not fall through to sshurl
            ok 1 - using the correct dummy hosted service
            ok 2 - expect rejected Promise
            1..2
        ok 3 - fail, but do not fall through to sshurl # time=16.308ms

        1..3
    ok 6 - include auth with hosted https when provided # time=37.016ms

    # Subtest: include .gitignore in hosted tarballs for preparation
        ok 1 - should be equivalent strictly
        1..1
    ok 7 - include .gitignore in hosted tarballs for preparation # time=782.304ms

    # Subtest: add git sha to hosted git shorthand
        ok 1 - should be equal
        1..1
    ok 8 - add git sha to hosted git shorthand # time=0.362ms

    # Subtest: fetch a weird ref
        # Subtest: hosted
            ok 1 - got git url as resolved value
            ok 2 - git url for HEAD~3 is not the same as HEAD
            1..2
        ok 1 - hosted # time=976.58ms

        # Subtest: regular
            ok 1 - got the same HEAD~3 sha as before
            1..1
        ok 2 - regular # time=991.106ms

        1..2
    ok 9 - fetch a weird ref # time=1968.807ms

    # Subtest: fetch a private repo where the tgz is a 404
        1..0
    ok 10 - fetch a private repo where the tgz is a 404 # time=955.112ms

    # Subtest: fetch a private repo where the tgz is not a tarball
        ok 1 - expect rejected Promise
        1..1
    ok 11 - fetch a private repo where the tgz is not a tarball # time=31.708ms

    # Subtest: resolved is a git+ssh url for hosted repos that support it
        ok 1 - should be equal
        1..1
    ok 12 - resolved is a git+ssh url for hosted repos that support it # time=0.31ms

    # Subtest: resolved preserves git+ssh url for non-hosted repos
        ok 1 - should be equal
        1..1
    ok 13 - resolved preserves git+ssh url for non-hosted repos # time=0.156ms

    # Subtest: fall back to ssh url if https url fails or is missing
        ok 1 - should be equal
        1..1
    ok 14 - fall back to ssh url if https url fails or is missing # time=887.654ms

    # Subtest: repoUrl function
        ok 1 - should match pattern provided
        ok 2 - should match pattern provided
        ok 3 - should match pattern provided
        ok 4 - should match pattern provided
        ok 5 - should match pattern provided
        1..5
    ok 15 - repoUrl function # time=0.543ms

    # Subtest: handle it when prepared git deps depend on each other
        ok 1 - should match pattern provided
        ok 2 - should be equivalent strictly
        ok 3 - does not continue installing once loop is detected
        ok 4 - should match pattern provided
        ok 5 - should be equivalent strictly
        ok 6 - does not continue installing once loop is detected
        1..6
    ok 16 - handle it when prepared git deps depend on each other # time=2965.555ms

    # Subtest: missing branch name throws pathspec error
        ok 1 - localhostssh
        ok 2 - localhostssh
        ok 3 - localhosthttps
        ok 4 - localhosthttps
        ok 5 - localhost
        ok 6 - localhost
        1..6
    ok 17 - missing branch name throws pathspec error # time=555.173ms

    # Subtest: simple repo with workspaces
        ok 1 - should run prepare phase when finding workspaces
        1..1
    ok 18 - simple repo with workspaces # time=794.939ms

    # Subtest: simple repo with only a prepack script
        ok 1 - should run prepack lifecycle script
        1..1
    ok 19 - simple repo with only a prepack script # time=855.146ms

    # Subtest: fails without arborist constructor
        ok 1 - expect rejected Promise
        1..1
    ok 20 - fails without arborist constructor # time=646.219ms

    1..20
    # time=19050.625ms
ok 8 - test/git.js # time=19050.625ms

    1..0 # no tests found
ok 9 - test/helpers/clean-snapshot.js # SKIP no tests found

    1..0 # no tests found
ok 10 - test/helpers/script-mode.js # SKIP no tests found

    ok 1 - a cache dir is ok
    ok 2 - should be equal
    ok 3 - should be equal
    ok 4 - should be equal
    ok 5 - should be equal
    ok 6 - should be equal
    ok 7 - should be equal
    ok 8 - should be equal
    ok 9 - should be equal
    ok 10 - should be equal
    ok 11 - should be equal
    ok 12 - should be equal
    ok 13 - should be equal
    1..13
    # time=2.555ms
ok 11 - test/util/cache-dir.js # time=2.555ms

    1..21
    ok 1 - git+ssh://git@some-host:user/repo + sha = git+ssh://git@some-host:user/repo\#sha
    ok 2 - git+ssh://git@some-host:user/repo\#othersha + sha = git+ssh://git@some-host:user/repo\#sha
    ok 3 - git+ssh://git@some-host:user/repo\#othersha\#otherothersha + sha = git+ssh://git@some-host:user/repo\#sha
    ok 4 - git+ssh://git@some-host/user/repo + sha = git+ssh://git@some-host/user/repo\#sha
    ok 5 - git+ssh://git@some-host/user/repo\#othersha + sha = git+ssh://git@some-host/user/repo\#sha
    ok 6 - git+ssh://git@some-host/user/repo\#othersha\#otherothersha + sha = git+ssh://git@some-host/user/repo\#sha
    ok 7 - github:user/repo + sha = github:user/repo\#sha
    ok 8 - github:user/repo\#othersha + sha = github:user/repo\#sha
    ok 9 - github:user/repo\#othersha\#otherothersha + sha = github:user/repo\#sha
    ok 10 - git+https://[email protected]/user/repo + sha = https://[email protected]/user/repo.git\#sha
    ok 11 - git+https://[email protected]/user/repo\#othersha + sha = https://[email protected]/user/repo.git\#sha
    ok 12 - git+https://[email protected]/user/repo\#othersha\#otherothersha + sha = https://[email protected]/user/repo.git\#sha
    ok 13 - git+https://github.com/user/repo + sha = github:user/repo\#sha
    ok 14 - git+https://github.com/user/repo\#othersha + sha = github:user/repo\#sha
    ok 15 - git+https://github.com/user/repo\#othersha\#otherothersha + sha = github:user/repo\#sha
    ok 16 - git+ssh://[email protected]/user/repo + sha = github:user/repo\#sha
    ok 17 - git+ssh://[email protected]/user/repo\#othersha + sha = github:user/repo\#sha
    ok 18 - git+ssh://[email protected]/user/repo\#othersha\#otherothersha + sha = github:user/repo\#sha
    ok 19 - git+ssh://[email protected]:user/repo + sha = github:user/repo\#sha
    ok 20 - git+ssh://[email protected]:user/repo\#othersha + sha = github:user/repo\#sha
    ok 21 - git+ssh://[email protected]:user/repo\#othersha\#otherothersha + sha = github:user/repo\#sha
    # time=4.384ms
ok 12 - test/util/add-git-sha.js # time=4.384ms

    # Subtest: do the things
        ok 1 - expect resolving Promise
        ok 2 - expect resolving Promise
        1..2
    ok 1 - do the things # time=10.538ms

    1..1
    # time=12.925ms
ok 13 - test/util/npm.js # time=12.925ms

    ok 1 - finds string
    ok 2 - finds in obj
    ok 3 - return false if pkg is not
    ok 4 - not the bin string
    ok 5 - not in obj
    1..5
    # time=1.543ms
ok 14 - test/util/is-package-bin.js # time=1.543ms

    ok 1 - should return standard options
    ok 2 - should not filter anything
    ok 3 - should return an executable stat
    ok 4 - should not filter out files
    1..4
    # time=1.555ms
ok 15 - test/util/tar-create-options.js # time=1.555ms

1..15
------------------------|---------|----------|---------|---------|-------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------------------|---------|----------|---------|---------|-------------------
All files               |     100 |      100 |     100 |     100 |
 bin                    |     100 |      100 |     100 |     100 |
  index.js              |     100 |      100 |     100 |     100 |
 lib                    |     100 |      100 |     100 |     100 |
  dir.js                |     100 |      100 |     100 |     100 |
  fetcher.js            |     100 |      100 |     100 |     100 |
  file.js               |     100 |      100 |     100 |     100 |
  git.js                |     100 |      100 |     100 |     100 |
  index.js              |     100 |      100 |     100 |     100 |
  registry.js           |     100 |      100 |     100 |     100 |
  remote.js             |     100 |      100 |     100 |     100 |
 lib/util               |     100 |      100 |     100 |     100 |
  add-git-sha.js        |     100 |      100 |     100 |     100 |
  cache-dir.js          |     100 |      100 |     100 |     100 |
  is-package-bin.js     |     100 |      100 |     100 |     100 |
  npm.js                |     100 |      100 |     100 |     100 |
  protected.js          |     100 |      100 |     100 |     100 |
  tar-create-options.js |     100 |      100 |     100 |     100 |
  trailing-slashes.js   |     100 |      100 |     100 |     100 |
------------------------|---------|----------|---------|---------|-------------------

> [email protected] posttest
> npm run lint

> [email protected] lint
> npm run eslint

> [email protected] eslint
> eslint "**/*.{js,cjs,ts,mjs,jsx,tsx}"

> [email protected] postlint
> template-oss-check
@owlstronaut owlstronaut marked this pull request as ready for review April 14, 2025 20:21
@owlstronaut owlstronaut requested a review from a team as a code owner April 14, 2025 20:21
wraithgar
wraithgar reviewed Apr 15, 2025
View reviewed changes
test/git.js
@@ -1,3 +1,6 @@
// `npm test --ignore-scripts` overrides any local options, so we need to remove it from the env
delete process.env.npm_config_ignore_scripts
Copy link
Member

@wraithgar wraithgar Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tap tests run in their own environments. This solution will likely not work if we ever switch from tap. Just something to put in the back of your head (i.e. we'll want to store/restore this instead of a blanket removal)

Copy link
Contributor Author

@owlstronaut owlstronaut Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@owlstronaut owlstronaut merged commit 0310b7b into main Apr 15, 2025
22 of 24 checks passed
@owlstronaut owlstronaut deleted the owlstronaut/ignore-scripts-fix branch April 15, 2025 14:15
@github-actions github-actions bot mentioned this pull request Jul 22, 2025
Merged
owlstronaut pushed a commit that referenced this pull request Sep 3, 2025
@github-actions
chore: release 21.0.1 (#427)
1fcf88f 
🤖 I have created a release *beep* *boop*
---


## [21.0.1](v21.0.0...v21.0.1)
(2025-09-02)
### Dependencies
*
[`aae7798`](aae7798)
[#428](#428)
`@npmcli/[email protected]`
*
[`1b233e3`](1b233e3)
[#428](#428)
`@npmcli/[email protected]`
*
[`d4b97ec`](d4b97ec)
[#428](#428) `[email protected]`
*
[`cf27487`](cf27487)
[#428](#428)
`[email protected]`
*
[`3e89235`](3e89235)
[#428](#428) `[email protected]`
*
[`d46fc27`](d46fc27)
[#428](#428) `[email protected]`
*
[`2a6a9f0`](2a6a9f0)
[#428](#428) `[email protected]`
*
[`bbb72cf`](bbb72cf)
[#428](#428) `[email protected]`
*
[`8a642c0`](8a642c0)
[#426](#426) `[email protected]` (#426)
### Chores
*
[`f81d8ed`](f81d8ed)
[#417](#417) bump @npmcli/arborist
from 8.0.0 to 9.0.0 (#417) (@dependabot[bot])
*
[`0310b7b`](0310b7b)
[#422](#422) tests should not inherit
--ignore-scripts flag from `npm run t… (#422) (@owlstronaut)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@owlstronaut @wraithgar