Skip to content

chore: tests should not inherit --ignore-scripts flag from `npm run t… #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owlstronaut merged 1 commit into from
Apr 15, 2025
+3 −0
Merged

chore: tests should not inherit --ignore-scripts flag from `npm run t… #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/git.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// `npm test --ignore-scripts` overrides any local options, so we need to remove it from the env
delete process.env.npm_config_ignore_scripts
Copy link
Member

@wraithgar wraithgar Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tap tests run in their own environments. This solution will likely not work if we ever switch from tap. Just something to put in the back of your head (i.e. we'll want to store/restore this instead of a blanket removal)

Copy link
Contributor Author

@owlstronaut owlstronaut Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!


const t = require('tap')
const fs = require('node:fs')
const http = require('node:http')
Expand Down