Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jN #17

Merged
merged 2 commits into from
Nov 27, 2018
Merged

jN #17

merged 2 commits into from
Nov 27, 2018

Conversation

KOLANICH
Copy link
Contributor

No description provided.

@chcg
Copy link
Contributor

chcg commented Nov 15, 2018

@KOLANICH

PluginAdmin has some needs, which are not fulfilled by the provided zip of jN:

Copy from: [Notepad++ Directory]\plugins\jN.dll To: $PLUGINDIR$\ Validate Directory
Copy from: [Notepad++ Directory]\plugins\jN\*.* To: $PLUGINDIR$\jN Directory

See https://notepad-plus-plus.org/features/plugin-admin.html point 6:
Packaging: Only zip package is supported. Your plugin (DLL) should have the same name as the "folder-name" and the plugin DLL file should be placed at the root level of the ZIP file. Otherwise Plugin Admin won't install it. Any additionals files (dll or data) can be placed at the root level or in an arbitrary subfolder.

So this plugin ( as others too) was intentionally not yet transferred from plugin managers list.

@sieukrem Please do a repackaging of the existing release so it could be added also to PA.

@chcg chcg added invalid This doesn't seem right delayed correction to the plugin needed from plugin author and removed invalid This doesn't seem right labels Nov 16, 2018
@chcg
Copy link
Contributor

chcg commented Nov 27, 2018

New jN version created which is compatible with PA.

@chcg chcg merged commit 2485e01 into notepad-plus-plus:master Nov 27, 2018
@KOLANICH
Copy link
Contributor Author

KOLANICH commented Nov 27, 2018

@chcg this commit contains the links leading to the old version and the hash of the old archive. I have no idea why you have merged it.

@KOLANICH KOLANICH deleted the jN branch November 27, 2018 21:40
@chcg chcg removed the delayed correction to the plugin needed from plugin author label Nov 27, 2018
@chcg chcg added this to the 1.0.3 milestone Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants