Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): sidebar navigation #451

Merged
merged 5 commits into from
Aug 18, 2018
Merged

Conversation

mhuggins
Copy link
Contributor

Description

This implements the sidebar navigation from the designs.

  • The sidebar links are clickable, and if the section is off the screen, will smoothly scroll into view.
  • The sidebar will automatically highlight the section that is active when scrolling.
  • The sidebar links are sticky so as to not be lost when scrolling.
  • The settings screen is responsive and will hide the sidebar for narrow windows.

Motivation and Context

Implement new designs.

How Has This Been Tested?

Smoke testing.

Screenshots (if appropriate)

settings-sidebar

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #403

@mhuggins mhuggins added the PR: needs review Pull request label Aug 18, 2018
@codecov
Copy link

codecov bot commented Aug 18, 2018

Codecov Report

Merging #451 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #451   +/-   ##
========================================
  Coverage    53.08%   53.08%           
========================================
  Files          153      153           
  Lines         1230     1230           
  Branches       161      161           
========================================
  Hits           653      653           
  Misses         486      486           
  Partials        91       91
Impacted Files Coverage Δ
src/renderer/shared/components/Page/Page.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7194b4...bb9ed8f. Read the comment docs.

}

registerRef = (el) => {
this.container = el;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue with #412 again?
The issue is closed and the PR got merged in 😄

Copy link
Member

@DalderupMaurice DalderupMaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noicee!

@DalderupMaurice DalderupMaurice merged commit f76c545 into develop Aug 18, 2018
@DalderupMaurice DalderupMaurice deleted the feat/settings-nav branch August 18, 2018 09:12
@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings sidebar
2 participants