Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(forms): forward component refs to DOM elements #412

Merged
merged 5 commits into from
Aug 26, 2018

Conversation

mhuggins
Copy link
Contributor

@mhuggins mhuggins commented Aug 5, 2018

NOTE: This PR is blocked until enzymejs/enzyme#1604 is fixed via enzymejs/enzyme#1592.

Description

This updates our form-based components to forward refs to the actual DOM element. This makes it so that the component does not need to expose functions specific to any element (e.g.: focus(), blur(), value).

Motivation and Context

Components should behave in an intuitive manner.

How Has This Been Tested?

Via the test suite and smoke testing.

Screenshots (if appropriate)

N/A

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

N/A

@mhuggins mhuggins added PR: don't merge This doesn't seem right blocked Blocked by another issue that must be completed first. labels Aug 5, 2018
@mhuggins mhuggins changed the title Chore/forward refs chore(forms): forward component refs to DOM elements Aug 5, 2018
@DalderupMaurice
Copy link
Member

Should be unblocked now 😄

@mhuggins
Copy link
Contributor Author

@DalderupMaurice They merged that PR, but they haven't published it in a release yet. I've been following closely. 😁

@codecov
Copy link

codecov bot commented Aug 25, 2018

Codecov Report

Merging #412 into develop will decrease coverage by 1.23%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #412      +/-   ##
===========================================
- Coverage    54.06%   52.82%   -1.24%     
===========================================
  Files          156      154       -2     
  Lines         1230     1185      -45     
  Branches       156      150       -6     
===========================================
- Hits           665      626      -39     
+ Misses         477      471       -6     
  Partials        88       88

@mhuggins mhuggins removed the blocked Blocked by another issue that must be completed first. label Aug 25, 2018
@mhuggins
Copy link
Contributor Author

This is unblocked now. I've got some tests to fix up, and then this will be golden.

@mhuggins mhuggins added PR: needs review Pull request and removed PR: don't merge This doesn't seem right labels Aug 26, 2018
@mhuggins
Copy link
Contributor Author

@DalderupMaurice This is ready for review now. 😃

Copy link
Member

@DalderupMaurice DalderupMaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :P

@mhuggins mhuggins merged commit af0adb2 into develop Aug 26, 2018
@mhuggins mhuggins deleted the chore/forward-refs branch August 26, 2018 18:40
@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: good to merge Reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants