Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add wide viewport hoc #628

Closed
wants to merge 4 commits into from

Conversation

gish
Copy link
Contributor

@gish gish commented Oct 16, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 99.593% when pulling 38aa443 on gish:feature/add-wide-viewport-hoc into efb2505 on nordnet:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9295edd on gish:feature/add-wide-viewport-hoc into efb2505 on nordnet:master.

@bstream
Copy link
Contributor

bstream commented Oct 17, 2017

This looks like it could be troublesome for SSR, see this issue: facebook/react#10591. Maybe we can investigate it together?

@bstream
Copy link
Contributor

bstream commented Sep 12, 2018

This has to be done with media queries for now since it does break SSR in React 16

@bstream bstream closed this Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants