Bugfix/upgrade linter (#627)

* Make lint work again

* Support mocha in eslint

* Use isFinite explicitly

* Define getComponentPaths before used

* Fix misspelt proptypes

* Remove nordnet eslint config

* Disable linting any prop types

* Remove nordnet eslint config from yarn lockfile

* Remove explicit use of isFinite

.eslintrc

@@ -1,15 +1,30 @@
 {
-  "extends": "eslint-config-nordnet",
-  "rules": {
-    "comma-dangle": 0,
-    "no-param-reassign": [2, { "props": false }],
-    "react/forbid-prop-types": 0,
-    "react/no-unused-prop-types": [ 2, { "skipShapeProps": true }],
-    "react/require-default-props": 0
-  },
+  "extends": [
+    "airbnb",
+    "prettier",
+    "prettier/react"
+  ],
+  "parser": "babel-eslint",
   "parserOptions": {
+    "ecmaVersion": 2016,
+    "sourceType": "module",
     "ecmaFeatures": {
-      "experimentalObjectRestSpread": true
+      "impliedStrict": true,
+      "jsx": true
     }
+  },
+  "plugins": [
+    "react"
+  ],
+  "env": {
+    "node": true,
+    "browser": true,
+    "es6": true,
+    "mocha": true
+  },
+  "rules": {
+    "import/no-extraneous-dependencies": 0,
+    "react/forbid-prop-types": [2, { "forbid": ["any", "array"] }],
+    "react/require-default-props": 0
   }
 }

package.json

@@ -71,6 +71,7 @@
     "autoprefixer": "^7.1.0",
     "babel-cli": "^6.24.0",
     "babel-core": "^6.24.0",
+    "babel-eslint": "^8.0.1",
     "babel-loader": "^7.0.0",
     "babel-plugin-transform-object-rest-spread": "^6.23.0",
     "babel-polyfill": "^6.23.0",
@@ -85,11 +86,11 @@
     "dirty-chai": "^1.2.2",
     "enzyme": "^2.8.0",
     "eslint": "^4.1.0",
-    "eslint-config-airbnb": "^15.0.0",
-    "eslint-config-nordnet": "^1.1.1",
-    "eslint-plugin-import": "^2.2.0",
+    "eslint-config-airbnb": "^16.0.0",
+    "eslint-config-prettier": "^2.6.0",
+    "eslint-plugin-import": "^2.7.0",
     "eslint-plugin-jsx-a11y": "^6.0.0",
-    "eslint-plugin-react": "^7.0.0",
+    "eslint-plugin-react": "^7.4.0",
     "extract-text-webpack-plugin": "^2.1.0",
     "git-directory-deploy": "^1.5.1",
     "husky": "^0.14.0",

src/components/addon/addon.jsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { PropTypes } from 'react';
 import classNames from 'classnames';
 
 /**
@@ -23,6 +23,6 @@ Addon.defaultProps = {
 };
 
 Addon.propTypes = {
-  className: React.PropTypes.string,
-  children: React.PropTypes.node.isRequired,
+  className: PropTypes.string,
+  children: PropTypes.node.isRequired,
 };

src/components/currency/currency.jsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { PropTypes } from 'react';
 import Number from '../number/number';
 import variables from '../../variables';
 
@@ -45,17 +45,17 @@ Currency.defaultProps = {
 };
 
 Currency.propTypes = {
-  value: React.PropTypes.any.isRequired,
+  value: PropTypes.any.isRequired, // eslint-disable-line
   /**
     Syntactic sugar for `suffix` (either one can be used)
   */
-  currency: React.PropTypes.string,
+  currency: PropTypes.string,
   /**
     Default is a space (`' '`)
   */
-  suffixSeparator: React.PropTypes.string,
-  suffixSize: React.PropTypes.oneOf(['normal', 'small']),
-  decimals: React.PropTypes.number,
-  maxDecimals: React.PropTypes.number,
-  minDecimals: React.PropTypes.number,
+  suffixSeparator: PropTypes.string,
+  suffixSize: PropTypes.oneOf(['normal', 'small']),
+  decimals: PropTypes.number,
+  maxDecimals: PropTypes.number,
+  minDecimals: PropTypes.number,
 };

src/components/date-time-iso/date-time-iso.jsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { PropTypes } from 'react';
 import isoDate from './iso-date';
 
 /**
@@ -38,20 +38,20 @@ DateTimeIso.defaultProps = {
 };
 
 DateTimeIso.propTypes = {
-  value: React.PropTypes.oneOfType([
-    React.PropTypes.number,
-    React.PropTypes.instanceOf(Date),
+  value: PropTypes.oneOfType([
+    PropTypes.number,
+    PropTypes.instanceOf(Date),
   ]).isRequired,
-  hour: React.PropTypes.oneOfType([
-    React.PropTypes.bool,
-    React.PropTypes.string,
+  hour: PropTypes.oneOfType([
+    PropTypes.bool,
+    PropTypes.string,
   ]),
-  minute: React.PropTypes.oneOfType([
-    React.PropTypes.bool,
-    React.PropTypes.string,
+  minute: PropTypes.oneOfType([
+    PropTypes.bool,
+    PropTypes.string,
   ]),
-  second: React.PropTypes.oneOfType([
-    React.PropTypes.bool,
-    React.PropTypes.string,
+  second: PropTypes.oneOfType([
+    PropTypes.bool,
+    PropTypes.string,
   ]),
 };

src/components/date-time/date-time.jsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { PropTypes } from 'react';
 import { FormattedDate, FormattedTime, FormattedRelative } from 'react-intl';
 import DateTimeIso from '../date-time-iso/date-time-iso';
 import formats from './date-time-formats';
@@ -40,19 +40,19 @@ DateTime.defaultProps = {
 };
 
 DateTime.propTypes = {
-  format: React.PropTypes.oneOf(['numeric', 'human']),
+  format: PropTypes.oneOf(['numeric', 'human']),
   /**
     Only applicable for dates, indicates that the date should follow [ISO 8601](https://sv.wikipedia.org/wiki/ISO_8601)
   */
-  iso: React.PropTypes.bool,
+  iso: PropTypes.bool,
   /**
     A timestamp.
   */
-  value: React.PropTypes.oneOfType([
-    React.PropTypes.number,
-    React.PropTypes.instanceOf(Date),
+  value: PropTypes.oneOfType([
+    PropTypes.number,
+    PropTypes.instanceOf(Date),
   ]).isRequired,
-  type: React.PropTypes.oneOf(['date', 'time', 'relative']),
+  type: PropTypes.oneOf(['date', 'time', 'relative']),
 };
 
 export default DateTime;

src/components/development/development.jsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { PropTypes } from 'react';
 import classNames from 'classnames';
 import NumberComponent from '../number/number';
 import CurrencyComponent from '../currency/currency';
@@ -70,13 +70,13 @@ export default function Development({
 }
 
 Development.propTypes = {
-  className: React.PropTypes.string,
-  value: React.PropTypes.any.isRequired,
-  decimals: React.PropTypes.number,
-  type: React.PropTypes.oneOf(['number', 'currency', 'percentage']),
-  direction: React.PropTypes.oneOf(['positive', 'negative', 'neutral']),
-  maxDecimals: React.PropTypes.number,
-  minDecimals: React.PropTypes.number,
+  className: PropTypes.string,
+  value: PropTypes.any.isRequired, // eslint-disable-line
+  decimals: PropTypes.number,
+  type: PropTypes.oneOf(['number', 'currency', 'percentage']),
+  direction: PropTypes.oneOf(['positive', 'negative', 'neutral']),
+  maxDecimals: PropTypes.number,
+  minDecimals: PropTypes.number,
 };
 
 Development.defaultProps = {

src/components/number/number.jsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { PropTypes } from 'react';
 import { injectIntl, intlShape } from 'react-intl';
 import classNames from 'classnames';
 import Addon from '../addon/addon';
@@ -75,29 +75,29 @@ function Number({
 }
 
 Number.propTypes = {
-  className: React.PropTypes.string,
-  style: React.PropTypes.object,
-  value: React.PropTypes.any.isRequired,
-  valueClass: React.PropTypes.string,
-  valueDecimals: React.PropTypes.number,
-  valueMaxDecimals: React.PropTypes.number,
-  valueMinDecimals: React.PropTypes.number,
-  valueStyle: React.PropTypes.object,
-  prefix: React.PropTypes.node,
-  prefixClass: React.PropTypes.string,
-  prefixSeparator: React.PropTypes.string,
-  prefixStyle: React.PropTypes.object,
-  suffix: React.PropTypes.node,
-  suffixClass: React.PropTypes.string,
-  suffixSeparator: React.PropTypes.string,
-  suffixStyle: React.PropTypes.object,
-  ticks: React.PropTypes.arrayOf(React.PropTypes.shape({
-    decimals: React.PropTypes.number,
-    to_price: React.PropTypes.number,
-    from_price: React.PropTypes.number,
-    tick: React.PropTypes.number,
+  className: PropTypes.string,
+  style: PropTypes.object,
+  value: PropTypes.any.isRequired, // eslint-disable-line
+  valueClass: PropTypes.string,
+  valueDecimals: PropTypes.number,
+  valueMaxDecimals: PropTypes.number,
+  valueMinDecimals: PropTypes.number,
+  valueStyle: PropTypes.object,
+  prefix: PropTypes.node,
+  prefixClass: PropTypes.string,
+  prefixSeparator: PropTypes.string,
+  prefixStyle: PropTypes.object,
+  suffix: PropTypes.node,
+  suffixClass: PropTypes.string,
+  suffixSeparator: PropTypes.string,
+  suffixStyle: PropTypes.object,
+  ticks: PropTypes.arrayOf(PropTypes.shape({
+    decimals: PropTypes.number,
+    to_price: PropTypes.number,
+    from_price: PropTypes.number,
+    tick: PropTypes.number,
   })),
-  intl: intlShape.isRequired,
+  intl: intlShape.isRequired, // eslint-disable-line react/no-typos
 };
 
 Number.defaultProps = {

src/components/percent/percent.jsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { PropTypes } from 'react';
 import Number from '../number/number';
 
 /**
@@ -33,12 +33,12 @@ Percent.defaultProps = {
 };
 
 Percent.propTypes = {
-  value: React.PropTypes.any.isRequired,
-  decimals: React.PropTypes.number,
+  value: PropTypes.any.isRequired, // eslint-disable-line
+  decimals: PropTypes.number,
   /**
     Default is an empty string (`''`)
   */
-  suffixSeparator: React.PropTypes.string,
-  maxDecimals: React.PropTypes.number,
-  minDecimals: React.PropTypes.number,
+  suffixSeparator: PropTypes.string,
+  maxDecimals: PropTypes.number,
+  minDecimals: PropTypes.number,
 };

src/components/value/value.jsx

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { PropTypes } from 'react';
 import Number from '../number/number';
 
 /**
@@ -29,8 +29,8 @@ Value.defaultProps = {
 };
 
 Value.propTypes = {
-  value: React.PropTypes.any.isRequired,
-  decimals: React.PropTypes.number,
-  maxDecimals: React.PropTypes.number,
-  minDecimals: React.PropTypes.number,
+  value: PropTypes.any.isRequired, // eslint-disable-line
+  decimals: PropTypes.number,
+  maxDecimals: PropTypes.number,
+  minDecimals: PropTypes.number,
 };

src/utils.js

@@ -1,5 +1,5 @@
 export function numberIsFinite(value) {
-  return typeof value === 'number' && isFinite(value);
+  return typeof value === 'number' && isFinite(value); // eslint-disable-line
 }
 
 export function getTickDecimals(value, ticks) {

styleguide/config.js

@@ -4,6 +4,10 @@ const autoprefixer = require('autoprefixer');
 const ExtractTextPlugin = require('extract-text-webpack-plugin');
 const config = require('../webpack.config.babel');
 
+function getComponentPaths(components) {
+  return components.map(componentPath => `${path.resolve(__dirname)}/${componentPath}`);
+}
+
 const numberComponentPaths = getComponentPaths([
   '../src/components/value/value.jsx',
   '../src/components/currency/currency.jsx',
@@ -17,10 +21,6 @@ const otherComponentPaths = getComponentPaths([
   '../src/components/icon-row/icon-row.jsx',
 ]);
 
-function getComponentPaths(components) {
-  return components.map(componentPath => `${path.resolve(__dirname)}/${componentPath}`);
-}
-
 function capitalize(string) {
   return string.charAt(0).toUpperCase() + string.slice(1);
 }