-
Notifications
You must be signed in to change notification settings - Fork 14
Fix Powerlevels and add Room Version 12 changes #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: afba230 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Review GuideThe big changes to the testsA note on the various test changes: 99% are just adding Which tests actually changed?The example widget's PowerLevelsPage, The example widget's RelationsPage, powerlevel tests in the api package Which other files are real changes?Basically the same as the tests. However also the example widget powerLevelsApi.ts, and the api package events.ts. There are some changes to the redux store which I assumed to need initially but did not end up needing. However I feel like this may come back as useful in the future so I decided to leave them for now. Use the right ticketWhile the branch points to NEO-1593 the actual ticket was later split out as NEO-1602 so please book on NEO-1602 :) |
maheichyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just few small comments added
Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
…ssing powerlevel Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
Signed-off-by: MTRNord <[email protected]>
df2cb6d to
afba230
Compare
We did quite a bit of stuff wrong. This aims to fix this and add the new room version 12 assumptions too.
The currently failing ui tests are mostly broken tests where redux store isnt applied, the user id isnt valid or we relied on incorrect permission assumptions.
✔️ Checklist
Signed-off-byline in the message (more info).