Skip to content

Conversation

@Marcel-Nordeck
Copy link
Contributor

@Marcel-Nordeck Marcel-Nordeck commented Aug 4, 2025

We did quite a bit of stuff wrong. This aims to fix this and add the new room version 12 assumptions too.

The currently failing ui tests are mostly broken tests where redux store isnt applied, the user id isnt valid or we relied on incorrect permission assumptions.

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

@Marcel-Nordeck Marcel-Nordeck self-assigned this Aug 4, 2025
@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025

🦋 Changeset detected

Latest commit: afba230

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@matrix-widget-toolkit/api Major
@matrix-widget-toolkit/testing Major
@matrix-widget-toolkit/mui Patch
@matrix-widget-toolkit/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Marcel-Nordeck
Copy link
Contributor Author

Review Guide

The big changes to the tests

A note on the various test changes: 99% are just adding :example.com to the user ids and room ids to match what we validate. This is necessary since for the Powerlevel related changes (powerlevel event validation specifically) we now check for the sender id and room id to be valid. However this means we had to change the default user and room id within the mockwidgetapi surface. Which essentially affects every test :/ There is no workaround other than fixing code debt here.

Which tests actually changed?

The example widget's PowerLevelsPage, The example widget's RelationsPage, powerlevel tests in the api package

Which other files are real changes?

Basically the same as the tests. However also the example widget powerLevelsApi.ts, and the api package events.ts. There are some changes to the redux store which I assumed to need initially but did not end up needing. However I feel like this may come back as useful in the future so I decided to leave them for now.

Use the right ticket

While the branch points to NEO-1593 the actual ticket was later split out as NEO-1602 so please book on NEO-1602 :)

@Marcel-Nordeck Marcel-Nordeck marked this pull request as ready for review August 7, 2025 20:11
@Marcel-Nordeck Marcel-Nordeck requested a review from a team as a code owner August 7, 2025 20:11
Copy link
Contributor

@maheichyk maheichyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just few small comments added

@Marcel-Nordeck Marcel-Nordeck merged commit 56a2fa1 into main Aug 11, 2025
5 checks passed
@Marcel-Nordeck Marcel-Nordeck deleted the nic/fix/NEO-1593-2 branch August 11, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants