Repository navigation
feat(profile)!: remove all legacy aliases and deprecation shims for v1.0.0 prep - #1826
Merged
Merged
Conversation
Contributor
PR Review SummarySize
Affected crates
Blast radius — BroadThis PR touches: source code,documentation,CI / build tooling,configuration / policy files Updated automatically on each push to this PR. |
![nogent-nolabs-ai[bot]](https://avatars.githubusercontent.com/in/4165202?s=60&v=4){kind=small}
…1.0.0 prep Drop 10 profile-key aliases, 9 CLI flag aliases, and 1 library alias. Delete deprecated_schema.rs and deprecated_policy.rs in full (the old flat profile schema and the nono policy subcommand), along with their test fixtures and scripts/test-list-aliases.sh. Update all documentation to stop describing removed aliases as still accepted. Breaking: legacy keys, flags, and subcommands now fail to parse instead of warning. Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
kurtisc
requested changes
Sep 9, 2026
kurtisc
left a comment
kurtisc
left a comment
Contributor
There was a problem hiding this comment.
This breaks /tests/integration/test_tls_intercept.sh for me
Member
Author
This is present on main regardless, my branch did not introduce this. I'll fix it though real quick |
Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
Member
Author
|
@kurtisc Fixed, + made an issue to wire them into our release PR workflow so we can catch out issues earlier |
kurtisc
approved these changes
Sep 10, 2026
kurtisc
left a comment
kurtisc
left a comment
Contributor
There was a problem hiding this comment.
It's nice to see a diff with this much red. Feel free to resolve the comments yourself.
Signed-off-by: Aleksy Siek <aleksy@nolabs.ai>
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #
Summary
Drop 10 profile-key aliases, 9 CLI flag aliases, and 1 library alias. Delete deprecated_schema.rs and deprecated_policy.rs in full (the old flat profile schema and the nono policy subcommand), along with their test fixtures and scripts/test-list-aliases.sh. Update all documentation to stop describing removed aliases as still accepted.
Breaking: legacy keys, flags, and subcommands now fail to parse instead of warning. Grace period of 21+ versions was given with printed warnings, more than enough time for change. Multiple months.
NEP: #1758
Test Plan
Checklist