Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scripts for using the NCEDC data stored on s3 #282

Closed
wants to merge 9 commits into from

Conversation

kuanfufeng
Copy link
Collaborator

This PR is for adding scripts/functions and a tutorial for using the NCEDC data stored on s3.

  • adding a format condition for the NCEDC XML format in channelcatalog.py
  • adding ncedc_3cstore.py by mimicking scedc_s3store.py
  • adding a notebook noisepy_ncedc_tutorial.ipynb for the tutorial

Kuan-Fu Feng and others added 7 commits January 22, 2024 10:08
* Migrated Read docs page

* Migrated Read docs page - Added full_socal.csv

* Added full_socal.csv

* Migrated Read docs page to Jupyter book and added relative markdown links in README.md. Added windows specific command in the get_started.ipynb

* Fixed os path

* Fixed os path

* Fixed os path

* Renamed docs folder to docs_old

* Addressed the issues
* refactor: update rm_resp from str to enum

* refactor: update tests

* added TODO for additional unit tests

to be covered on: #250

Co-authored-by: carlosgjs <[email protected]>

* added TODO for test updates

---------

Co-authored-by: carlosgjs <[email protected]>
* Fixed Issue #174

* Incorporating the helper functions

* Adding TODO

* Adding TODO
* refactor: update plot_waveform() to use the (ASDF)RawDataStore

* style: pre-commit hook restyle

* refactor: update plot_waveform() to use the (ASDF)RawDataStore. codefix

* style: pre-commit hook restyle

* style: pre-commit hook restyle

* refactor: update plot_waveform() to use the (ASDF)RawDataStore
Fixed minor bugs in 3 plotting functions in the plotting_modules.py
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (baae80e) 75.81% compared to head (3199026) 75.77%.

Files Patch % Lines
src/noisepy/seis/channelcatalog.py 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   75.81%   75.77%   -0.05%     
==========================================
  Files          39       39              
  Lines        4425     4429       +4     
  Branches      603      604       +1     
==========================================
+ Hits         3355     3356       +1     
- Misses        925      927       +2     
- Partials      145      146       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlosgjs
Copy link
Collaborator

@kuanfufeng - Looks like you need to update your branch, e.g.

git checkout main
git pull
git checkout kuanfu_ncedc
git merge main
# resolve any conflicts and commit the merge
git push

Copy link
Collaborator

@carlosgjs carlosgjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment about updating the branch

@kuanfufeng
Copy link
Collaborator Author

See above comment about updating the branch

My bad. It has failed somewhere. Let me close this PR and start over again by creating a branch on the up-to-date main.

@kuanfufeng kuanfufeng closed this Jan 24, 2024
@kuanfufeng kuanfufeng deleted the kuanfu_ncedc branch January 24, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants