Fix: incorrect plotting function behaviors in plotting_modules.py #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed minor bugs in 3 plotting functions in the plotting_modules.py
YantaoLuo
requested review from
mdenolle,
niyiyu,
carlosgjs and
chengxinjiang
as code owners
YantaoLuo
changed the title
YantaoLuo
commented
Jan 3, 2024
YantaoLuo
commented
Jan 3, 2024
YantaoLuo
commented
Jan 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 75.81% 75.81%
=======================================
Files 39 39
Lines 4425 4425
Branches 603 603
=======================================
Hits 3355 3355
Misses 925 925
Partials 145 145 ☔ View full report in Codecov by Sentry. |
|
@YantaoLuo thanks for the fixes! Can you paste/attach a plot with the fixes to the description of the PR please? That will be very helpful. |
niyiyu
approved these changes
Jan 6, 2024
kuanfufeng
pushed a commit
that referenced
this pull request
Jan 24, 2024
Fixed minor bugs in 3 plotting functions in the plotting_modules.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will fix minor bugs in 3 plotting functions (plot_substack_cc, plot_all_moveout, plot_all_moveout_1D_1comp) in the plotting_modules.py. Before and after plots as well as more detailed explanations are attached.
PR_plotfix_comparison_Yantao.pdf