-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Install noir-profiler and noir-inspector #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 20 commits
08946b0
53fc84a
2c2e79a
60e8425
0c95394
9c3767a
f7b750f
05c0334
d7e0755
d37e906
f8dfc2d
c59d7b1
189b116
17231f9
760d611
59a471b
eb0b350
d79bf4a
47328c3
db89304
8a698f6
3236926
93fabc7
d176ae3
81d2e19
01255e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,6 +79,20 @@ jobs: | |
| run: noirup ${{steps.parse.outputs.toolchain}} | ||
| - name: Check nargo installation | ||
| run: nargo --version | ||
| - name: Check noir-profiler installation | ||
| run: | | ||
| # Fetch the version from `nargo` as to also check the `stable` and `nightly` toolchains | ||
| VERSION=$(nargo --version | awk -F' = ' '/nargo version/ {print $2}') | ||
| # Minimum version which began releasing binaries for the `noir-profiler` | ||
|
vezenovm marked this conversation as resolved.
Outdated
|
||
| MIN_VERSION="1.0.0-beta.3" | ||
|
|
||
| version_gte() { | ||
| [ "$(printf '%s\n' "$1" "$2" | sort -V | head -n1)" = "$2" ] | ||
| } | ||
|
|
||
| if version_gte "$VERSION" "$MIN_VERSION"; then | ||
| noir-profiler --version | ||
| fi | ||
|
Comment on lines
+82
to
+107
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test is a little tuatological. We're running What I've done elsewhere in this workflow is to split the version number into major, minor, patch and we can then assert that after a certain version we expect the profiler to exist. |
||
|
|
||
| install-source: | ||
| name: Noir ${{matrix.version}} (from source) on ${{matrix.os == 'ubuntu' && 'Linux' || matrix.os == 'macos' && 'macOS' || matrix.os == 'windows' && 'Windows' || '???'}} | ||
|
|
@@ -116,6 +130,17 @@ jobs: | |
| toolchain: -b tags/${{matrix.version}} | ||
| - name: Check nargo installation | ||
| run: nargo --version | ||
| - name: Check noir-profiler installation | ||
| run: | | ||
| MIN_VERSION="v1.0.0-beta.3" | ||
|
vezenovm marked this conversation as resolved.
|
||
|
|
||
| version_gte() { | ||
| [ "$(printf '%s\n' "$1" "$2" | sort -V | head -n1)" = "$2" ] | ||
| } | ||
|
|
||
| if version_gte ${{matrix.version}} "$MIN_VERSION"; then | ||
| noir-profiler --version | ||
| fi | ||
|
|
||
| install-action: | ||
| name: Noir ${{matrix.toolchain}} (GH action) on ${{matrix.os == 'ubuntu' && 'Linux' || matrix.os == 'macos' && 'macOS' || matrix.os == 'windows' && 'Windows' || '???'}} | ||
|
|
@@ -151,3 +176,18 @@ jobs: | |
| working-directory: ./project | ||
| - run: nargo test | ||
| working-directory: ./project | ||
| - name: Check noir-profiler installation | ||
| working-directory: ./project | ||
| run: | | ||
| VERSION=$(nargo --version | awk -F' = ' '/nargo version/ {print $2}') | ||
| # Minimum version which began releasing binaries for the `noir-profiler`. | ||
|
vezenovm marked this conversation as resolved.
Outdated
|
||
| MIN_VERSION="1.0.0-beta.3" | ||
|
|
||
| version_gte() { | ||
| [ "$(printf '%s\n' "$1" "$2" | sort -V | head -n1)" = "$2" ] | ||
| } | ||
|
|
||
| if version_gte "$VERSION" "$MIN_VERSION"; then | ||
| noir-profiler --version | ||
| noir-profiler opcodes -a ./target/project.json -o ./target | ||
| fi | ||
Uh oh!
There was an error while loading. Please reload this page.