feat: Install noir-profiler and noir-inspector#46
Merged
TomAFrench merged 26 commits intomainfrom Feb 20, 2025
Merged
Conversation
vezenovm
commented
Feb 19, 2025
vezenovm
commented
Feb 19, 2025
vezenovm
commented
Feb 19, 2025
TomAFrench
reviewed
Feb 20, 2025
Comment on lines
+82
to
+86
| - name: Check noir-profiler installation | ||
| run: | | ||
| if [ -f "${HOME}/.nargo/bin/noir-profiler" ]; then | ||
| noir-profiler --version | ||
| fi |
Member
There was a problem hiding this comment.
This test is a little tuatological. We're running noir-profiler --version to check if it's there but only if it's there.
What I've done elsewhere in this workflow is to split the version number into major, minor, patch and we can then assert that after a certain version we expect the profiler to exist.
TomAFrench
reviewed
Feb 20, 2025
Member
|
LGTM, let's merge this after 1.0.0-beta.3 goes out so we can test it with a |
vezenovm
commented
Feb 20, 2025
vezenovm
commented
Feb 20, 2025
vezenovm
commented
Feb 20, 2025
vezenovm
commented
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #42
Summary*
This PR simply adds handling for installation of the noir-profiler from source. It uses the new tarball name
noir-{architecture}-{platform}that contains all Noir binaries after noir-lang/noir#7443.Adding an additional binary requires a couple changes to be compatible with older versions of Noir. Most notably we do a check against
curl {new binary url}to determine whether we need to use the old binary url name.When compiling from source we switched to checking whether a binary exists before attempting to move it.
Additional Context
We probably could also rename
.nargoto.noiras we now have Noir binaries that are not contained to just nargo. However, I feel we can do this switch later.PR Checklist*
cargo fmton default settings.