chore(acir_gen): Remove Brillig execution with constant arguments

[vezenovm]

Description

Problem*

Working towards green-lighting ACIR gen.

Quite some time ago we introduced the ability to execute the Brillig VM if a call was made with all constant inputs. This was a bit of a workaround as we did not run any SSA optimizations over Brillig and did not yet constant fold Brillig entry points.

Summary*

I removed Brillig execution logic from the brillig_call module of ACIR gen. This should simplify the logic and lets us keep a better separation of concerns for each pass.

With regards to stdlib functions, we already check for constant inputs before we lay down an Inverse or Quotient and perform the appropriate computation. This will be necessary for any new Brillig stdlib functions.

We also get the nice side benefit of removing the B: BlackBoxFunctionSolver<F> generic on the AcirContext.

Additional Context

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

ACVM Benchmarks

Details

Benchmark suite	Current: ac85898	Previous: 0eead18	Ratio
purely_sequential_opcodes	250911 ns/iter (± 271)	256545 ns/iter (± 1171)	0.98
perfectly_parallel_opcodes	223932 ns/iter (± 3436)	229968 ns/iter (± 770)	0.97
perfectly_parallel_batch_inversion_opcodes	2795919 ns/iter (± 2344)	2817715 ns/iter (± 2957)	0.99

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: ac85898	Previous: 0eead18	Ratio
private-kernel-inner	0.02 s	0.016 s	1.25

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

Compilation Time

Details

Benchmark suite	Current: ac85898	Previous: 0eead18	Ratio
private-kernel-inner	1.914 s	1.832 s	1.04
private-kernel-reset	8.232 s	8.882 s	0.93
private-kernel-tail	1.342 s	1.368 s	0.98
rollup-base-private	17.58 s	18.4 s	0.96
rollup-base-public	16.42 s	17.94 s	0.92
rollup-block-root-empty	17.42 s	16.88 s	1.03
rollup-block-root-single-tx	198 s	208 s	0.95
rollup-block-root	202 s	197 s	1.03
rollup-merge	1.356 s	1.38 s	0.98
rollup-root	1.518 s	1.632 s	0.93
semaphore-depth-10	0.806 s	0.776 s	1.04
sha512-100-bytes	1.969 s	1.882 s	1.05

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Execution Time

Details

Benchmark suite	Current: ac85898	Previous: 0eead18	Ratio
private-kernel-inner	0.02 s	0.016 s	1.25
private-kernel-reset	0.161 s	0.162 s	0.99
private-kernel-tail	0.01 s	0.01 s	1
rollup-base-private	0.265 s	0.268 s	0.99
rollup-base-public	0.158 s	0.162 s	0.98
rollup-block-root	14.4 s	14.8 s	0.97
rollup-merge	0.002 s	0.002 s	1
rollup-root	0.004 s	0.004 s	1
semaphore-depth-10	0.019 s	0.019 s	1
sha512-100-bytes	0.101 s	0.1 s	1.01

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Artifact Size

Details

Benchmark suite	Current: ac85898	Previous: 0eead18	Ratio
private-kernel-inner	712.1 KB	712.1 KB	1
private-kernel-reset	1983.6 KB	1983.6 KB	1
private-kernel-tail	506.6 KB	506.6 KB	1
rollup-base-private	4361.8 KB	4361.8 KB	1
rollup-base-public	3365.6 KB	3365.6 KB	1
rollup-block-root-empty	3852.6 KB	3851.2 KB	1.00
rollup-block-root-single-tx	30879.7 KB	30879.7 KB	1
rollup-block-root	30908.3 KB	30908.3 KB	1
rollup-merge	189.1 KB	189.1 KB	1
rollup-root	391.2 KB	391.2 KB	1
semaphore-depth-10	634 KB	634 KB	1
sha512-100-bytes	527.6 KB	527.6 KB	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Opcode count

Details

Benchmark suite	Current: ac85898	Previous: 0eead18	Ratio
private-kernel-inner	14792 opcodes	14792 opcodes	1
private-kernel-reset	68868 opcodes	68868 opcodes	1
private-kernel-tail	11177 opcodes	11177 opcodes	1
rollup-base-private	221346 opcodes	221346 opcodes	1
rollup-base-public	159937 opcodes	159937 opcodes	1
rollup-block-root-empty	67910 opcodes	67868 opcodes	1.00
rollup-block-root-single-tx	963687 opcodes	963687 opcodes	1
rollup-block-root	964973 opcodes	964973 opcodes	1
rollup-merge	1409 opcodes	1409 opcodes	1
rollup-root	2619 opcodes	2619 opcodes	1
semaphore-depth-10	5700 opcodes	5700 opcodes	1
sha512-100-bytes	13173 opcodes	13173 opcodes	1

This comment was automatically generated by workflow using github-action-benchmark.

[asterite]

Nice!

[github-actions]

Test Suite Duration

Details

Benchmark suite	Current: ac85898	Previous: 0eead18	Ratio
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr	103 s	103 s	1
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts	132 s	130 s	1.02
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob	200 s	216 s	0.93
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib	219 s	218 s	1.00
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_reset-kernel-lib	33 s	36 s	0.92
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_rollup-lib	618 s	680 s	0.91
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types	98 s	97 s	1.01
test_report_noir-lang_noir-bignum_	134 s	133 s	1.01
test_report_noir-lang_noir_bigcurve_	314 s	315 s	1.00
test_report_noir-lang_sha256_	17 s	15 s	1.13
test_report_noir-lang_sha512_	13 s	13 s	1
test_report_zkpassport_noir-ecdsa_	2 s	1 s	2
test_report_zkpassport_noir_rsa_	1 s	1 s	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: ac85898	Previous: 0eead18	Ratio
test_report_zkpassport_noir-ecdsa_	2 s	1 s	2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

Execution Memory

Details

Benchmark suite	Current: ac85898	Previous: 0eead18	Ratio
private-kernel-inner	258.74 MB	258.74 MB	1
private-kernel-reset	291.13 MB	291.13 MB	1
private-kernel-tail	242.63 MB	242.63 MB	1
rollup-base-private	506.72 MB	506.72 MB	1
rollup-base-public	440.02 MB	440.02 MB	1
rollup-block-root	1530 MB	1530 MB	1
rollup-merge	331.06 MB	331.06 MB	1
rollup-root	333.58 MB	333.58 MB	1
semaphore_depth_10	73 MB	73 MB	1
sha512_100_bytes	69.57 MB	69.57 MB	1

This comment was automatically generated by workflow using github-action-benchmark.

[github-actions]

Compilation Memory

Details

Benchmark suite	Current: ac85898	Previous: 0eead18	Ratio
private-kernel-inner	285.18 MB	285.16 MB	1.00
private-kernel-reset	593.15 MB	593.15 MB	1
private-kernel-tail	258.98 MB	258.98 MB	1
rollup-base-private	1360 MB	1360 MB	1
rollup-base-public	1420 MB	1420 MB	1
rollup-block-root-empty	1020 MB	1020 MB	1
rollup-block-root-single-tx	9680 MB	9680 MB	1
rollup-block-root	9690 MB	9690 MB	1
rollup-merge	333.29 MB	333.29 MB	1
rollup-root	344 MB	344 MB	1
semaphore_depth_10	107.77 MB	107.77 MB	1
sha512_100_bytes	265.65 MB	265.7 MB	1.00

This comment was automatically generated by workflow using github-action-benchmark.