chore(ssa): Flatten basic Brillig conditionals before inlining of simple functions#9761
Closed
chore(ssa): Flatten basic Brillig conditionals before inlining of simple functions#9761
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ACVM Benchmarks
Details
| Benchmark suite | Current: 7a9096a | Previous: d664016 | Ratio |
|---|---|---|---|
purely_sequential_opcodes |
247106 ns/iter (± 2781) |
251068 ns/iter (± 637) |
0.98 |
perfectly_parallel_opcodes |
218221 ns/iter (± 5528) |
222699 ns/iter (± 4162) |
0.98 |
perfectly_parallel_batch_inversion_opcodes |
2784648 ns/iter (± 24888) |
2803001 ns/iter (± 1089) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
There was a problem hiding this comment.
Compilation Time
Details
| Benchmark suite | Current: 7a9096a | Previous: d664016 | Ratio |
|---|---|---|---|
private-kernel-inner |
1.9 s |
1.778 s |
1.07 |
private-kernel-reset |
8.426 s |
8.418 s |
1.00 |
private-kernel-tail |
1.362 s |
1.334 s |
1.02 |
rollup-base-private |
18.82 s |
19.02 s |
0.99 |
rollup-base-public |
16.54 s |
16.08 s |
1.03 |
rollup-block-root-empty |
17.44 s |
17.42 s |
1.00 |
rollup-block-root-single-tx |
198 s |
194 s |
1.02 |
rollup-block-root |
214 s |
210 s |
1.02 |
rollup-merge |
1.414 s |
1.378 s |
1.03 |
rollup-root |
1.474 s |
1.508 s |
0.98 |
semaphore-depth-10 |
0.791 s |
0.788 s |
1.00 |
sha512-100-bytes |
1.808 s |
1.835 s |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Artifact Size
Details
| Benchmark suite | Current: 7a9096a | Previous: d664016 | Ratio |
|---|---|---|---|
private-kernel-inner |
709.8 KB |
709.5 KB |
1.00 |
private-kernel-reset |
2025.1 KB |
2025.1 KB |
1 |
private-kernel-tail |
531.6 KB |
531.7 KB |
1.00 |
rollup-base-private |
4349 KB |
4349 KB |
1 |
rollup-base-public |
3353.3 KB |
3353.3 KB |
1 |
rollup-block-root-empty |
3813.5 KB |
3813.5 KB |
1 |
rollup-block-root-single-tx |
30682.4 KB |
30682.4 KB |
1 |
rollup-block-root |
30720.4 KB |
30720.4 KB |
1 |
rollup-merge |
188.1 KB |
188.1 KB |
1 |
rollup-root |
390.6 KB |
390.6 KB |
1 |
semaphore-depth-10 |
631.9 KB |
631.9 KB |
1 |
sha512-100-bytes |
525.5 KB |
525.5 KB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Opcode count
Details
| Benchmark suite | Current: 7a9096a | Previous: d664016 | Ratio |
|---|---|---|---|
private-kernel-inner |
14792 opcodes |
14792 opcodes |
1 |
private-kernel-reset |
68868 opcodes |
68868 opcodes |
1 |
private-kernel-tail |
11177 opcodes |
11177 opcodes |
1 |
rollup-base-private |
221339 opcodes |
221339 opcodes |
1 |
rollup-base-public |
159930 opcodes |
159930 opcodes |
1 |
rollup-block-root-empty |
68108 opcodes |
68108 opcodes |
1 |
rollup-block-root-single-tx |
964515 opcodes |
964515 opcodes |
1 |
rollup-block-root |
965801 opcodes |
965801 opcodes |
1 |
rollup-merge |
1409 opcodes |
1409 opcodes |
1 |
rollup-root |
2631 opcodes |
2631 opcodes |
1 |
semaphore-depth-10 |
5700 opcodes |
5700 opcodes |
1 |
sha512-100-bytes |
13173 opcodes |
13173 opcodes |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Time
Details
| Benchmark suite | Current: 7a9096a | Previous: d664016 | Ratio |
|---|---|---|---|
private-kernel-inner |
0.017 s |
0.015 s |
1.13 |
private-kernel-reset |
0.162 s |
0.163 s |
0.99 |
private-kernel-tail |
0.011 s |
0.011 s |
1 |
rollup-base-private |
0.267 s |
0.266 s |
1.00 |
rollup-base-public |
0.166 s |
0.161 s |
1.03 |
rollup-block-root |
14.5 s |
14.4 s |
1.01 |
rollup-merge |
0.002 s |
0.002 s |
1 |
rollup-root |
0.004 s |
0.004 s |
1 |
semaphore-depth-10 |
0.019 s |
0.021 s |
0.90 |
sha512-100-bytes |
0.102 s |
0.092 s |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
Author
|
The results are not wide reaching enough to make me want to merge this as is so I am closing the PR. The main takeaway is that the |
Contributor
There was a problem hiding this comment.
Compilation Memory
Details
| Benchmark suite | Current: 7a9096a | Previous: d664016 | Ratio |
|---|---|---|---|
private-kernel-inner |
284.51 MB |
284.57 MB |
1.00 |
private-kernel-reset |
593.53 MB |
593.53 MB |
1 |
private-kernel-tail |
259.08 MB |
259.08 MB |
1 |
rollup-base-private |
1360 MB |
1360 MB |
1 |
rollup-base-public |
1420 MB |
1420 MB |
1 |
rollup-block-root-empty |
998.82 MB |
998.82 MB |
1 |
rollup-block-root-single-tx |
9680 MB |
9680 MB |
1 |
rollup-block-root |
9690 MB |
9690 MB |
1 |
rollup-merge |
332.74 MB |
332.74 MB |
1 |
rollup-root |
343.48 MB |
343.48 MB |
1 |
semaphore_depth_10 |
106.96 MB |
106.96 MB |
1 |
sha512_100_bytes |
254.08 MB |
254.12 MB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Memory
Details
| Benchmark suite | Current: 7a9096a | Previous: d664016 | Ratio |
|---|---|---|---|
private-kernel-inner |
258.16 MB |
258.16 MB |
1 |
private-kernel-reset |
291.32 MB |
291.32 MB |
1 |
private-kernel-tail |
242.9 MB |
242.9 MB |
1 |
rollup-base-private |
506.04 MB |
506.04 MB |
1 |
rollup-base-public |
438.42 MB |
438.42 MB |
1 |
rollup-block-root |
1500 MB |
1500 MB |
1 |
rollup-merge |
330.5 MB |
330.5 MB |
1 |
rollup-root |
333.02 MB |
333.02 MB |
1 |
semaphore_depth_10 |
72.45 MB |
72.45 MB |
1 |
sha512_100_bytes |
58.23 MB |
58.23 MB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Test Suite Duration
Details
| Benchmark suite | Current: 7a9096a | Previous: d664016 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr |
99 s |
100 s |
0.99 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts |
129 s |
127 s |
1.02 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
218 s |
223 s |
0.98 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib |
214 s |
219 s |
0.98 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_reset-kernel-lib |
33 s |
34 s |
0.97 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_rollup-lib |
641 s |
592 s |
1.08 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types |
98 s |
95 s |
1.03 |
test_report_noir-lang_noir-bignum_ |
133 s |
139 s |
0.96 |
test_report_noir-lang_noir_bigcurve_ |
318 s |
349 s |
0.91 |
test_report_noir-lang_sha256_ |
15 s |
15 s |
1 |
test_report_noir-lang_sha512_ |
12 s |
13 s |
0.92 |
test_report_zkpassport_noir-ecdsa_ |
1 s |
2 s |
0.50 |
test_report_zkpassport_noir_rsa_ |
1 s |
1 s |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
No issue just something I noticed when working on #9487. There are sometimes functions that would have a lot of knockdown simplifications but get muddled as being complex due to having multiple blocks.
Summary*
I am pushing this as a draft to see if it has any large effect on compilation times.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.