chore: some mem2reg refactors regarding expressions and aliases by asterite · Pull Request #9610 · noir-lang/noir

asterite · 2025-08-21T20:08:38Z

Description

Problem

Part of #9393

Summary

This PR tries to make the code more meaningful by removing some duplicated code and trying to avoid leaking some implementation details (although mem2reg is not very bug and it mostly knowns how everything is actually implemented). But the goal is to make the code easier to read, with less ifs.

Then I also found out that is_store_alias_used could be slightly refactored as well. Now it doesn't call the any method on AliasSet, which had checks like value == Some(true), and I also think it might be slightly faster as we need to traverse the alias set just once.

Additional Context

Now AliasSet has an iter() method. I wanted to have impl IntoIterator for &AliasSet so it can be iterated without having to call .iter() but I couldn't find a way to do it without having IntoIterator use Box<dyn Iterator...>, resulting in a heap allocation.

Documentation

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

ACVM Benchmarks

Details

Benchmark suite	Current: `eed09d5`	Previous: `5cc5e13`	Ratio
`purely_sequential_opcodes`	`248342` ns/iter (`± 1309`)	`249522` ns/iter (`± 1477`)	`1.00`
`perfectly_parallel_opcodes`	`223769` ns/iter (`± 3010`)	`217760` ns/iter (`± 4427`)	`1.03`
`perfectly_parallel_batch_inversion_opcodes`	`2779218` ns/iter (`± 8542`)	`2786420` ns/iter (`± 2697`)	`1.00`

This comment was automatically generated by workflow using github-action-benchmark.

compiler/noirc_evaluator/src/ssa/opt/mem2reg/block.rs

github-actions

Opcode count

Details

Benchmark suite	Current: `eed09d5`	Previous: `5cc5e13`	Ratio
`private-kernel-inner`	`14792` opcodes	`14792` opcodes	`1`
`private-kernel-reset`	`68868` opcodes	`68868` opcodes	`1`
`private-kernel-tail`	`11177` opcodes	`11177` opcodes	`1`
`rollup-base-private`	`221323` opcodes	`221323` opcodes	`1`
`rollup-base-public`	`159942` opcodes	`159942` opcodes	`1`
`rollup-block-root-empty`	`68106` opcodes	`68106` opcodes	`1`
`rollup-block-root-single-tx`	`963851` opcodes	`963851` opcodes	`1`
`rollup-block-root`	`965137` opcodes	`965137` opcodes	`1`
`rollup-merge`	`1409` opcodes	`1409` opcodes	`1`
`rollup-root`	`2631` opcodes	`2631` opcodes	`1`
`semaphore-depth-10`	`5700` opcodes	`5700` opcodes	`1`
`sha512-100-bytes`	`13173` opcodes	`13173` opcodes	`1`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Artifact Size

Details

Benchmark suite	Current: `eed09d5`	Previous: `5cc5e13`	Ratio
`private-kernel-inner`	`709.1` KB	`709.1` KB	`1`
`private-kernel-reset`	`2033.1` KB	`2033.1` KB	`1`
`private-kernel-tail`	`535.9` KB	`535.9` KB	`1`
`rollup-base-private`	`4317.7` KB	`4317.7` KB	`1`
`rollup-base-public`	`3329.6` KB	`3329.6` KB	`1`
`rollup-block-root-empty`	`3846.8` KB	`3846.8` KB	`1`
`rollup-block-root-single-tx`	`30728.8` KB	`30728.8` KB	`1`
`rollup-block-root`	`30774.4` KB	`30774.4` KB	`1`
`rollup-merge`	`187` KB	`187` KB	`1`
`rollup-root`	`388.9` KB	`388.9` KB	`1`
`semaphore-depth-10`	`631.5` KB	`631.5` KB	`1`
`sha512-100-bytes`	`525.2` KB	`525.2` KB	`1`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Execution Time

Details

Benchmark suite	Current: `eed09d5`	Previous: `5cc5e13`	Ratio
`private-kernel-inner`	`0.013` s	`0.013` s	`1`
`private-kernel-reset`	`0.154` s	`0.156` s	`0.99`
`private-kernel-tail`	`0.01` s	`0.01` s	`1`
`rollup-base-private`	`0.266` s	`0.263` s	`1.01`
`rollup-base-public`	`0.173` s	`0.164` s	`1.05`
`rollup-block-root`	`13` s	`13` s	`1`
`rollup-merge`	`0.002` s	`0.002` s	`1`
`rollup-root`	`0.004` s	`0.004` s	`1`
`semaphore-depth-10`	`0.019` s	`0.018` s	`1.06`
`sha512-100-bytes`	`0.096` s	`0.101` s	`0.95`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Compilation Time

Details

Benchmark suite	Current: `eed09d5`	Previous: `5cc5e13`	Ratio
`private-kernel-inner`	`1.82` s	`1.678` s	`1.08`
`private-kernel-reset`	`7.726` s	`7.786` s	`0.99`
`private-kernel-tail`	`1.402` s	`1.302` s	`1.08`
`rollup-base-private`	`16.1` s	`15.12` s	`1.06`
`rollup-base-public`	`13.36` s	`14.16` s	`0.94`
`rollup-block-root-empty`	`20.46` s	`20.9` s	`0.98`
`rollup-block-root-single-tx`	`207` s	`207` s	`1`
`rollup-block-root`	`195` s	`205` s	`0.95`
`rollup-merge`	`1.324` s	`1.408` s	`0.94`
`rollup-root`	`1.426` s	`1.432` s	`1.00`
`semaphore-depth-10`	`0.762` s	`0.746` s	`1.02`
`sha512-100-bytes`	`1.638` s	`1.599` s	`1.02`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `52d33be`	Previous: `5cc5e13`	Ratio
`private-kernel-inner`	`0.018` s	`0.013` s	`1.38`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions

Compilation Memory

Details

Benchmark suite	Current: `eed09d5`	Previous: `5cc5e13`	Ratio
`private-kernel-inner`	`239.89` MB	`239.85` MB	`1.00`
`private-kernel-reset`	`549.11` MB	`549.11` MB	`1`
`private-kernel-tail`	`213.85` MB	`213.85` MB	`1`
`rollup-base-private`	`1350` MB	`1350` MB	`1`
`rollup-base-public`	`1420` MB	`1420` MB	`1`
`rollup-block-root-empty`	`1090` MB	`1090` MB	`1`
`rollup-block-root-single-tx`	`9520` MB	`9520` MB	`1`
`rollup-block-root`	`9520` MB	`9520` MB	`1`
`rollup-merge`	`330.56` MB	`330.56` MB	`1`
`rollup-root`	`341.33` MB	`341.33` MB	`1`
`semaphore_depth_10`	`104.76` MB	`104.76` MB	`1`
`sha512_100_bytes`	`234.58` MB	`234.6` MB	`1.00`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Execution Memory

Details

Benchmark suite	Current: `eed09d5`	Previous: `5cc5e13`	Ratio
`private-kernel-inner`	`206.72` MB	`206.72` MB	`1`
`private-kernel-reset`	`243.54` MB	`243.54` MB	`1`
`private-kernel-tail`	`195.95` MB	`195.95` MB	`1`
`rollup-base-private`	`500.25` MB	`500.25` MB	`1`
`rollup-base-public`	`432.89` MB	`432.89` MB	`1`
`rollup-block-root`	`1500` MB	`1500` MB	`1`
`rollup-merge`	`328.19` MB	`328.19` MB	`1`
`rollup-root`	`330.55` MB	`330.55` MB	`1`
`semaphore_depth_10`	`69.5` MB	`69.5` MB	`1`
`sha512_100_bytes`	`54.99` MB	`54.99` MB	`1`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Test Suite Duration

Details

Benchmark suite	Current: `eed09d5`	Previous: `4d74333`	Ratio
`test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr`	`98` s
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts`	`109` s	`110` s	`0.99`
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob`	`186` s
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib`	`210` s
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_reset-kernel-lib`	`34` s	`31` s	`1.10`
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_rollup-lib`	`672` s
`test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types`	`101` s	`97` s	`1.04`
`test_report_noir-lang_noir-bignum_`	`346` s
`test_report_noir-lang_noir_bigcurve_`	`289` s
`test_report_noir-lang_sha256_`	`14` s	`15` s	`0.93`
`test_report_noir-lang_sha512_`	`13` s	`15` s	`0.87`
`test_report_zkpassport_noir-ecdsa_`	`2` s	`1` s	`2`
`test_report_zkpassport_noir_rsa_`	`2` s	`2` s	`1`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `eed09d5`	Previous: `4d74333`	Ratio
`test_report_zkpassport_noir-ecdsa_`	`2` s	`1` s	`2`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: some mem2reg refactors regarding expressions and aliases (noir-lang/noir#9610) feat: keep last loads from predecessors in mem2reg (noir-lang/noir#9492) chore: Update flattening docs (noir-lang/noir#9588) chore: remove redundant globals creation (noir-lang/noir#9606) chore: simplify Expression in mem2reg (noir-lang/noir#9599) chore: remove duplicate `contains_reference` in mem2reg (noir-lang/noir#9602) chore!: remove `verify_signature_slice` methods from stdlib (noir-lang/noir#9597) fix(expand): correctly handle nested dereferences (noir-lang/noir#9598) fix(ssa): Do not simplify on lhs being zero for shifts (noir-lang/noir#9596) chore: store last loads in `HashSet` instead of `HashMap` in mem2reg (noir-lang/noir#9498) chore: `--no-ssa-locations` for `nargo interpret` and show negative values when printing SSA (noir-lang/noir#9586) fix: `assert_constant` refactors and fixes from audit (noir-lang/noir#9547) fix(ssa): Consider `shl` and `shr` to have side effects (noir-lang/noir#9580) fix: avoid invalid cast in `remove_bit_shifts` (noir-lang/noir#9570) fix(mem2reg): Consider aliases of a loaded address to be loaded from as well (noir-lang/noir#9567) fix: Consume correct number of fields when printing references (noir-lang/noir#9579) chore: Add a section for numeric type aliases (noir-lang/noir#9589) chore(remove_paired_rc): Add various unit tests (noir-lang/noir#9425) fix: incorrect max bit size in `remove_bit_shifts` (noir-lang/noir#9585) chore(ssa): Simplify shl/shr identity operations (noir-lang/noir#9587) chore: greenlight `brillig_array_get_and_set` for audits (noir-lang/noir#9540) chore(ssa): Update comments on `loop_invariant` for audit and some missing unit tests (noir-lang/noir#9574) chore: Switch to node v22.15.0 (noir-lang/noir#9582) chore: Update unrolling docs for audit (noir-lang/noir#9572) chore: greenlight `array_set_optimization` (noir-lang/noir#9560) fix(acir_gen): Keep range checks before side effects (noir-lang/noir#9340) END_COMMIT_OVERRIDE

asterite added 7 commits August 21, 2025 11:49

chore: simplify Expression in mem2reg

2158590

Merge branch 'master' into ab/mem2reg_simplify_expression

670d0cd

mem2reg: let for_each_alias_of take &self instead of &mut self

04bc798

Add AliasSet::iter

c2d586c

Add Block::aliases_of

4faf09b

Unify aliases_of and get_aliases_of_value

9446e75

Simplify is_store_alias_used

49625ae

asterite added the bench-show Display benchmark results on PR label Aug 21, 2025

asterite added 3 commits August 21, 2025 17:13

Merge branch 'master' into ab/mem2reg_iterators

6099f65

Simplify keep_last_stores_for

f7a933c

Avoid clone

52d33be

github-actions bot reviewed Aug 21, 2025

View reviewed changes

Slightly less noise

eed09d5

asterite commented Aug 21, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/opt/mem2reg/block.rs Show resolved Hide resolved

github-actions bot reviewed Aug 21, 2025

View reviewed changes

asterite requested a review from a team August 21, 2025 20:41

jfecher approved these changes Aug 21, 2025

View reviewed changes

asterite added this pull request to the merge queue Aug 21, 2025

Merged via the queue into master with commit 38473c1 Aug 21, 2025
122 checks passed

asterite deleted the ab/mem2reg_iterators branch August 21, 2025 21:47

AztecBot mentioned this pull request Aug 22, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#16490

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: some mem2reg refactors regarding expressions and aliases#9610

chore: some mem2reg refactors regarding expressions and aliases#9610
asterite merged 11 commits intomasterfrom
ab/mem2reg_iterators

asterite commented Aug 21, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

asterite commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Summary

Additional Context

Documentation

PR Checklist

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

ACVM Benchmarks

Uh oh!

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Opcode count

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Artifact Size

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Execution Time

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Compilation Time

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Compilation Memory

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Execution Memory

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Test Suite Duration

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

asterite commented Aug 21, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading

github-actions bot left a comment •

edited

Loading