chore: `--no-ssa-locations` for `nargo interpret` and show negative values when printing SSA by asterite · Pull Request #9586 · noir-lang/noir

asterite · 2025-08-20T17:28:46Z

Description

Problem

No issue, just a couple of things I noticed.

Summary

--no-ssa-locations didn't work for nargo interpret
A value like let x: i8 = -53 was displayed as i8 203 which was a bit confusing, so now negative values are printed as such

Additional Context

I wonder if --no-ssa-locations should be the default and instead have --with-ssa-locations. I find that I usually don't want locations and remember too late when I already pasted an SSA in an issue or PR.

Documentation

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `7a62c08`	Previous: `1f16498`	Ratio
`test_report_zkpassport_noir_rsa_`	`2` s	`1` s	`2`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

compiler/noirc_evaluator/src/ssa/ir/printer.rs

tooling/ast_fuzzer/src/program/tests.rs

…inting-signed-types

…o fix it

acvm-repo/acir_field/src/field_element.rs

acvm-repo/acir_field/src/generic_ark.rs

aakoshh

Awesome 👏

vezenovm · 2025-08-21T13:52:20Z

I wonder if --no-ssa-locations should be the default and instead have --with-ssa-locations. I find that I usually don't want locations and remember too late when I already pasted an SSA in an issue or PR.

I agree this would be nice. I usually do not want locations.

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: some mem2reg refactors regarding expressions and aliases (noir-lang/noir#9610) feat: keep last loads from predecessors in mem2reg (noir-lang/noir#9492) chore: Update flattening docs (noir-lang/noir#9588) chore: remove redundant globals creation (noir-lang/noir#9606) chore: simplify Expression in mem2reg (noir-lang/noir#9599) chore: remove duplicate `contains_reference` in mem2reg (noir-lang/noir#9602) chore!: remove `verify_signature_slice` methods from stdlib (noir-lang/noir#9597) fix(expand): correctly handle nested dereferences (noir-lang/noir#9598) fix(ssa): Do not simplify on lhs being zero for shifts (noir-lang/noir#9596) chore: store last loads in `HashSet` instead of `HashMap` in mem2reg (noir-lang/noir#9498) chore: `--no-ssa-locations` for `nargo interpret` and show negative values when printing SSA (noir-lang/noir#9586) fix: `assert_constant` refactors and fixes from audit (noir-lang/noir#9547) fix(ssa): Consider `shl` and `shr` to have side effects (noir-lang/noir#9580) fix: avoid invalid cast in `remove_bit_shifts` (noir-lang/noir#9570) fix(mem2reg): Consider aliases of a loaded address to be loaded from as well (noir-lang/noir#9567) fix: Consume correct number of fields when printing references (noir-lang/noir#9579) chore: Add a section for numeric type aliases (noir-lang/noir#9589) chore(remove_paired_rc): Add various unit tests (noir-lang/noir#9425) fix: incorrect max bit size in `remove_bit_shifts` (noir-lang/noir#9585) chore(ssa): Simplify shl/shr identity operations (noir-lang/noir#9587) chore: greenlight `brillig_array_get_and_set` for audits (noir-lang/noir#9540) chore(ssa): Update comments on `loop_invariant` for audit and some missing unit tests (noir-lang/noir#9574) chore: Switch to node v22.15.0 (noir-lang/noir#9582) chore: Update unrolling docs for audit (noir-lang/noir#9572) chore: greenlight `array_set_optimization` (noir-lang/noir#9560) fix(acir_gen): Keep range checks before side effects (noir-lang/noir#9340) END_COMMIT_OVERRIDE

asterite added 2 commits August 20, 2025 14:17

fix: honor --no-ssa-locations in nargo interpret

1f872f3

Let SSA printer show negative values as such

73d2987

github-actions bot reviewed Aug 20, 2025

View reviewed changes

Fix snapshot

2d8a209

asterite added the Blocked PR is blocked on an issue label Aug 20, 2025

aakoshh reviewed Aug 21, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/ir/printer.rs Show resolved Hide resolved

aakoshh reviewed Aug 21, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/ir/printer.rs Outdated Show resolved Hide resolved

aakoshh reviewed Aug 21, 2025

View reviewed changes

tooling/ast_fuzzer/src/program/tests.rs Show resolved Hide resolved

asterite removed the Blocked PR is blocked on an issue label Aug 21, 2025

asterite added 5 commits August 21, 2025 09:15

Merge branch 'master' into ab/nargo-interpret-no-ssa-locations-and-pr…

5682258

…inting-signed-types

Move format_field_string to AcirField::to_short_hex

84efea7

Extract FieldElement::to_string_as_signed_integer

5e940ea

Less strict formatting, otherwise a test fails and I don't know how t…

96390e2

…o fix it

Document the number function

7a62c08

aakoshh reviewed Aug 21, 2025

View reviewed changes

acvm-repo/acir_field/src/field_element.rs Outdated Show resolved Hide resolved

aakoshh reviewed Aug 21, 2025

View reviewed changes

acvm-repo/acir_field/src/generic_ark.rs Show resolved Hide resolved

asterite added 2 commits August 21, 2025 10:14

Document to_hex and add tests

283dabc

Small optimization

5212f8d

aakoshh approved these changes Aug 21, 2025

View reviewed changes

asterite enabled auto-merge August 21, 2025 13:23

asterite added this pull request to the merge queue Aug 21, 2025

Merged via the queue into master with commit 75a0e3e Aug 21, 2025
122 checks passed

asterite deleted the ab/nargo-interpret-no-ssa-locations-and-printing-signed-types branch August 21, 2025 14:02

AztecBot mentioned this pull request Aug 22, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#16490

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: `--no-ssa-locations` for `nargo interpret` and show negative values when printing SSA#9586

chore: `--no-ssa-locations` for `nargo interpret` and show negative values when printing SSA#9586
asterite merged 10 commits intomasterfrom
ab/nargo-interpret-no-ssa-locations-and-printing-signed-types

asterite commented Aug 20, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aakoshh left a comment

Uh oh!

vezenovm commented Aug 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

asterite commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Summary

Additional Context

Documentation

PR Checklist

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aakoshh left a comment

Choose a reason for hiding this comment

Uh oh!

vezenovm commented Aug 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

asterite commented Aug 20, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading