fix: assert types are not mutated in constant folding#9481
Merged
TomAFrench merged 6 commits intomasterfrom Aug 13, 2025
Merged
fix: assert types are not mutated in constant folding#9481TomAFrench merged 6 commits intomasterfrom
TomAFrench merged 6 commits intomasterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: c1f9de8 | Previous: b51b616 | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
2 s |
1 s |
2 |
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 05939f9 | Previous: b51b616 | Ratio |
|---|---|---|---|
private-kernel-tail |
0.013 s |
0.01 s |
1.30 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 05939f9 | Previous: b51b616 | Ratio |
|---|---|---|---|
private-kernel-tail |
1.788 s |
1.328 s |
1.35 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
jfecher
approved these changes
Aug 13, 2025
This was referenced Aug 14, 2025
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 15, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: restore noir libs in CI (noir-lang/noir#9499) feat!: new semantic for bit-shifts (noir-lang/noir#9373) fix(ssa): Replace side effects with defaults when disabled (noir-lang/noir#9462) fix(ssa): Replace pop from 0-length slice with constraint and defaults (noir-lang/noir#9489) fix: assert types are not mutated in constant folding (noir-lang/noir#9481) fix: remove shadowing in `BoundedVec::any` causing returning false unconditionally (noir-lang/noir#9478) END_COMMIT_OVERRIDE
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 15, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: restore noir libs in CI (noir-lang/noir#9499) feat!: new semantic for bit-shifts (noir-lang/noir#9373) fix(ssa): Replace side effects with defaults when disabled (noir-lang/noir#9462) fix(ssa): Replace pop from 0-length slice with constraint and defaults (noir-lang/noir#9489) fix: assert types are not mutated in constant folding (noir-lang/noir#9481) fix: remove shadowing in `BoundedVec::any` causing returning false unconditionally (noir-lang/noir#9478) END_COMMIT_OVERRIDE
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 15, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: restore noir libs in CI (noir-lang/noir#9499) feat!: new semantic for bit-shifts (noir-lang/noir#9373) fix(ssa): Replace side effects with defaults when disabled (noir-lang/noir#9462) fix(ssa): Replace pop from 0-length slice with constraint and defaults (noir-lang/noir#9489) fix: assert types are not mutated in constant folding (noir-lang/noir#9481) fix: remove shadowing in `BoundedVec::any` causing returning false unconditionally (noir-lang/noir#9478) END_COMMIT_OVERRIDE
mralj
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 13, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: restore noir libs in CI (noir-lang/noir#9499) feat!: new semantic for bit-shifts (noir-lang/noir#9373) fix(ssa): Replace side effects with defaults when disabled (noir-lang/noir#9462) fix(ssa): Replace pop from 0-length slice with constraint and defaults (noir-lang/noir#9489) fix: assert types are not mutated in constant folding (noir-lang/noir#9481) fix: remove shadowing in `BoundedVec::any` causing returning false unconditionally (noir-lang/noir#9478) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #9477
Resolves #9480
Summary*
This PR adds tests to catch types being mutated inside of constant folding.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.