fix: remove shadowing in BoundedVec::any causing returning false unconditionally#9478
Merged
TomAFrench merged 3 commits intonoir-lang:masterfrom Aug 13, 2025
Conversation
Contributor
|
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
TomAFrench
changed the title
BoundedVec::any causing returning false unconditionally
TomAFrench
approved these changes
Aug 13, 2025
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
Thanks for flagging this up! LGTM
Merged
via the queue into
noir-lang:master
with commit Aug 13, 2025
b51b616
119 of 120 checks passed
This was referenced Aug 14, 2025
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 15, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: restore noir libs in CI (noir-lang/noir#9499) feat!: new semantic for bit-shifts (noir-lang/noir#9373) fix(ssa): Replace side effects with defaults when disabled (noir-lang/noir#9462) fix(ssa): Replace pop from 0-length slice with constraint and defaults (noir-lang/noir#9489) fix: assert types are not mutated in constant folding (noir-lang/noir#9481) fix: remove shadowing in `BoundedVec::any` causing returning false unconditionally (noir-lang/noir#9478) END_COMMIT_OVERRIDE
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 15, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: restore noir libs in CI (noir-lang/noir#9499) feat!: new semantic for bit-shifts (noir-lang/noir#9373) fix(ssa): Replace side effects with defaults when disabled (noir-lang/noir#9462) fix(ssa): Replace pop from 0-length slice with constraint and defaults (noir-lang/noir#9489) fix: assert types are not mutated in constant folding (noir-lang/noir#9481) fix: remove shadowing in `BoundedVec::any` causing returning false unconditionally (noir-lang/noir#9478) END_COMMIT_OVERRIDE
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 15, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: restore noir libs in CI (noir-lang/noir#9499) feat!: new semantic for bit-shifts (noir-lang/noir#9373) fix(ssa): Replace side effects with defaults when disabled (noir-lang/noir#9462) fix(ssa): Replace pop from 0-length slice with constraint and defaults (noir-lang/noir#9489) fix: assert types are not mutated in constant folding (noir-lang/noir#9481) fix: remove shadowing in `BoundedVec::any` causing returning false unconditionally (noir-lang/noir#9478) END_COMMIT_OVERRIDE
mralj
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 13, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: restore noir libs in CI (noir-lang/noir#9499) feat!: new semantic for bit-shifts (noir-lang/noir#9373) fix(ssa): Replace side effects with defaults when disabled (noir-lang/noir#9462) fix(ssa): Replace pop from 0-length slice with constraint and defaults (noir-lang/noir#9489) fix: assert types are not mutated in constant folding (noir-lang/noir#9481) fix: remove shadowing in `BoundedVec::any` causing returning false unconditionally (noir-lang/noir#9478) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the shadowed ret inside the constrained branch of BoundedVec::any, using the outer accumulator instead.
This bug caused any to always return false when is_unconstrained() was false, even if the predicate matched an element.