fix(LSP): don't crash on broken function definition#9441
Merged
TomAFrench merged 2 commits intomasterfrom Aug 11, 2025
Merged
Conversation
TomAFrench
approved these changes
Aug 11, 2025
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Aug 12, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(LSP): don't crash on broken function definition (noir-lang/noir#9441) feat(opt): Don't clone on array_len (noir-lang/noir#9440) feat(ssa_fuzzer): mode without instruction simplification + array instructions mutations + limits fix (noir-lang/noir#9438) feat(fuzz): Push and pop for slices (noir-lang/noir#9262) fix(brillig_vm): Remove slice padding for foreign call inputs (noir-lang/noir#9321) fix: allow calling private impl method defined on another module from… (noir-lang/noir#9449) fix: guard `Eq` for `[T]` to avoid OOB on length mismatch (noir-lang/noir#9453) chore: bump external pinned commits (noir-lang/noir#9454) END_COMMIT_OVERRIDE Co-authored-by: AztecBot <tech@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
No issue, just something I noticed while writing some Noir code.
Summary
LSP crashed on the documentSymbol request on code like "fn foo(", that is, a function with an unclosed parentheses.
The issue was that the function body ended up having the location since "(" until the end, but the end token always had a dummy location of zero. This PR changes that location to be the actual end of the file. This might solve many LSP issues with broken code where a node's location end up having part of its location computed from the end token location.
Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.