Skip to content

chore: put back flatten_cfg checks #9362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asterite wants to merge 1 commit into from
Closed

chore: put back flatten_cfg checks #9362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions compiler/noirc_evaluator/src/ssa/opt/flatten_cfg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,14 @@ impl Ssa {

for function in self.functions.values_mut() {
// Disabled due to failures
// #[cfg(debug_assertions)]
// flatten_cfg_pre_check(function);
#[cfg(debug_assertions)]
flatten_cfg_pre_check(function);

flatten_function_cfg(function, &no_predicates);

// Disabled as we're getting failures, I would expect this to pass however.
// #[cfg(debug_assertions)]
// flatten_cfg_post_check(function);
#[cfg(debug_assertions)]
flatten_cfg_post_check(function);
}
self
}
Expand Down Expand Up @@ -1634,8 +1634,8 @@ mod test {
// The original function is replaced by the following:
let src = "
acir(inline) fn main f1 {
b0():
jmpif u1 0 then: b1, else: b2
b0(v0: u1):
jmpif v0 then: b1, else: b2
b1():
jmp b2()
b2():
Expand All @@ -1648,7 +1648,9 @@ mod test {
let ssa = ssa.flatten_cfg();
assert_ssa_snapshot!(ssa, @r"
acir(inline) fn main f0 {
b0():
b0(v0: u1):
enable_side_effects v0
v1 = not v0
enable_side_effects u1 1
constrain u1 0 == u1 1
return
Expand Down
Loading