Skip to content

chore: put back flatten_cfg checks#9362

Closed
asterite wants to merge 1 commit intomasterfrom
ab/flatten_cfg_checks
Closed

chore: put back flatten_cfg checks#9362
asterite wants to merge 1 commit intomasterfrom
ab/flatten_cfg_checks

Conversation

@asterite
Copy link
Collaborator

Description

Problem

Follow up to #9200

Summary

#9200 introduced a couple of checks but they were left commented because of a failure. It turns out that in the failing test's SSA the precondition didn't hold, so it made sense for it to fail. I slightly adjusted the test so it doesn't fail (not sure if that changes the test's purposes though).

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite requested review from vezenovm and removed request for vezenovm July 30, 2025 16:52
@asterite
Copy link
Collaborator Author

@vezenovm Sorry, accidentally clicked on asking a review but I didn't want to

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 3655b28 Previous: 28abb68 Ratio
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob 3 s 2 s 1.50
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@asterite
Copy link
Collaborator Author

Hm, it seems failures still happen in real programs...

@asterite asterite closed this Jul 30, 2025
@asterite asterite deleted the ab/flatten_cfg_checks branch July 30, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant