fix: add parent traits when adding trait impl where clause#9000
Merged
fix: add parent traits when adding trait impl where clause#9000
Conversation
jfecher
approved these changes
Jun 23, 2025
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jun 24, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: Implement type suffixes (noir-lang/noir#8970) fix: add parent traits when adding trait impl where clause (noir-lang/noir#9000) fix(fuzz): Use indirection for taking `&mut` over an array element (noir-lang/noir#8992) chore: remove unreachable functions after inlining simple functions (noir-lang/noir#8987) chore: bump external pinned commits (noir-lang/noir#8990) END_COMMIT_OVERRIDE Co-authored-by: AztecBot <tech@aztecprotocol.com>
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jun 24, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: Implement type suffixes (noir-lang/noir#8970) fix: add parent traits when adding trait impl where clause (noir-lang/noir#9000) fix(fuzz): Use indirection for taking `&mut` over an array element (noir-lang/noir#8992) chore: remove unreachable functions after inlining simple functions (noir-lang/noir#8987) chore: bump external pinned commits (noir-lang/noir#8990) END_COMMIT_OVERRIDE Co-authored-by: AztecBot <tech@aztecprotocol.com>
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: Implement type suffixes (noir-lang/noir#8970) fix: add parent traits when adding trait impl where clause (noir-lang/noir#9000) fix(fuzz): Use indirection for taking `&mut` over an array element (noir-lang/noir#8992) chore: remove unreachable functions after inlining simple functions (noir-lang/noir#8987) chore: bump external pinned commits (noir-lang/noir#8990) END_COMMIT_OVERRIDE Co-authored-by: AztecBot <tech@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #8999
Summary
It seems I forgot to add parent traits recursively in one place. When removing them it's already recursive.
Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.