chore: remove unreachable functions after inlining simple functions#8987
Merged
TomAFrench merged 5 commits intomasterfrom Jun 23, 2025
Merged
chore: remove unreachable functions after inlining simple functions#8987TomAFrench merged 5 commits intomasterfrom
TomAFrench merged 5 commits intomasterfrom
Conversation
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Member
Author
|
huh? |
Member
Author
|
Ah, looks like this affects the weights applied to different functions as the simple functions which are now removed would have still contributed to the weight of the functions which they called. |
aakoshh
reviewed
Jun 20, 2025
compiler/noirc_evaluator/src/ssa/opt/inline_simple_functions.rs
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 5759862 | Previous: 3838c69 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
172 s |
141 s |
1.22 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
aakoshh
approved these changes
Jun 23, 2025
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jun 24, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: Implement type suffixes (noir-lang/noir#8970) fix: add parent traits when adding trait impl where clause (noir-lang/noir#9000) fix(fuzz): Use indirection for taking `&mut` over an array element (noir-lang/noir#8992) chore: remove unreachable functions after inlining simple functions (noir-lang/noir#8987) chore: bump external pinned commits (noir-lang/noir#8990) END_COMMIT_OVERRIDE Co-authored-by: AztecBot <tech@aztecprotocol.com>
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jun 24, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: Implement type suffixes (noir-lang/noir#8970) fix: add parent traits when adding trait impl where clause (noir-lang/noir#9000) fix(fuzz): Use indirection for taking `&mut` over an array element (noir-lang/noir#8992) chore: remove unreachable functions after inlining simple functions (noir-lang/noir#8987) chore: bump external pinned commits (noir-lang/noir#8990) END_COMMIT_OVERRIDE Co-authored-by: AztecBot <tech@aztecprotocol.com>
5 tasks
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jul 16, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: Implement type suffixes (noir-lang/noir#8970) fix: add parent traits when adding trait impl where clause (noir-lang/noir#9000) fix(fuzz): Use indirection for taking `&mut` over an array element (noir-lang/noir#8992) chore: remove unreachable functions after inlining simple functions (noir-lang/noir#8987) chore: bump external pinned commits (noir-lang/noir#8990) END_COMMIT_OVERRIDE Co-authored-by: AztecBot <tech@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
In aztec-packages we have a glut of small functions which hang around in the SSA for a long time after being inlined. This PR integrates the
remove_unreachable_functionspass into theinline_simple_functionspass so we can remove these asap.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.