chore(fuzz): Tool to minimize Noir programs with `cvise` by aakoshh · Pull Request #8789 · noir-lang/noir

aakoshh · 2025-06-04T15:57:42Z

Description

Problem*

Resolves #8535

Summary*

Add scripts to utilise cvise to minimise the Noir programs produced by the AST fuzzer.

See the README for how to use and an example.

Additional Context

cvise has binaries for Linux, but not for Mac. For other platforms, using Docker is an option.

Since it works by calling a script to compile the input program, it needs access to nargo, so I made a Dockefile that installs nargo and cvise as well.

The idea is that we will mount a Noir project that replicates some issue, and then tell it to minimise it. We have to rebuild the image if we need to test a new version of nargo itself, but at we don't have to worry about mounting nargo from the developer machine, or cross building.

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `8af6edf`	Previous: `ce2fc37`	Ratio
`rollup-merge`	`0.004` s	`0.003` s	`1.33`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

tooling/ast_fuzzer/minimizer/scripts/minimize.sh

tooling/ast_fuzzer/minimizer/scripts/docker-entry.sh

asterite

Looks great! I'm currently running it so I'm waiting to get a minimization for the code in the first example, but it's running so it's working :-)

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `8af6edf`	Previous: `ce2fc37`	Ratio
`test_report_zkpassport_noir_rsa_`	`3` s	`2` s	`1.50`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

…5-cvise

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore(docs): Update noirjs app page to use to beta.6 (noir-lang/noir#8853) fix: support recursive call to main function in SSA parser (noir-lang/noir#8760) chore(SSA): validate that constrain values have the same type (noir-lang/noir#8850) fix: Comptime field division should error when the rhs is zero (noir-lang/noir#8845) chore: redo typo PR by osrm (noir-lang/noir#8840) fix: (SSA interpreter) to_le_bits returns [u1; _], not [u8; _] (noir-lang/noir#8837) chore(ssa): Initial validation module (noir-lang/noir#8765) chore: bump external pinned commits (noir-lang/noir#8834) feat(fuzz): Generate arbitrary constraints (noir-lang/noir#8820) fix: bind self generic type in trait calls via a concrete type in more cases (noir-lang/noir#8827) fix(comptime): Overflow on shl (noir-lang/noir#8829) fix(interpreter): Return -1 for negative shr signed overflow or 0 for positive shr signed overflow (noir-lang/noir#8828) feat(ssa_fuzzer): branching + constrains (noir-lang/noir#8599) chore(docs): Add experimental warning in Debugger docs (noir-lang/noir#8824) fix: Thread errors through remove_if_else instead of panicing when the value merger finds reference values (noir-lang/noir#8783) fix(interpreter): Do not overflow on signed checked ops (noir-lang/noir#8806) feat: short circuit creation of `Type::InfixExpr` containing errors (noir-lang/noir#8826) fix(mem2reg): Keep last stores used in array returned from a function (noir-lang/noir#8801) chore(ci): `cargo clippy` CI script to save time (noir-lang/noir#8787) chore: only follow bindings on interface to `arithmetic` module (noir-lang/noir#8822) fix: bind self generic type in trait calls via a concrete type (noir-lang/noir#8825) chore(docs): Reorder tooling docs (noir-lang/noir#8742) chore: small fix for outdated docs (noir-lang/noir#8821) fix(mem2reg): Keep last stores used in MakeArray (noir-lang/noir#8743) fix!: Error when re-assigning a mutable reference (noir-lang/noir#8790) fix!: indexing arrays with non-u32 is now an error (noir-lang/noir#8804) fix: signed right shift overflows to 0 or -1 (noir-lang/noir#8805) chore(fuzz): Tool to minimize Noir programs with `cvise` (noir-lang/noir#8789) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

aakoshh added 3 commits June 4, 2025 16:47

Add docker build script to AST fuzzer

491a7ee

Script to minimize a file looking for an error

bb51b4d

Create empty Prover.toml file if it doesn't exist

f620ad6

aakoshh marked this pull request as ready for review June 5, 2025 12:54

aakoshh requested review from a team, michaeljklein and rkarabut June 5, 2025 12:54

Add readme for the minimizer

f5c17f1

aakoshh force-pushed the af/8535-cvise branch from 8e3e620 to f5c17f1 Compare June 5, 2025 12:57

github-actions bot reviewed Jun 5, 2025

View reviewed changes

aakoshh force-pushed the af/8535-cvise branch from f9b7f1b to 96e2370 Compare June 5, 2025 13:22

Add one more example

dd45ddf

aakoshh force-pushed the af/8535-cvise branch from 96e2370 to dd45ddf Compare June 5, 2025 13:23

asterite reviewed Jun 5, 2025

View reviewed changes

tooling/ast_fuzzer/minimizer/scripts/minimize.sh Show resolved Hide resolved

aakoshh commented Jun 5, 2025

View reviewed changes

tooling/ast_fuzzer/minimizer/scripts/docker-entry.sh Show resolved Hide resolved

asterite approved these changes Jun 5, 2025

View reviewed changes

Merge branch 'master' into af/8535-cvise

8af6edf

github-actions bot reviewed Jun 5, 2025

View reviewed changes

aakoshh enabled auto-merge June 5, 2025 19:11

aakoshh added 3 commits June 6, 2025 08:43

Make minimize.sh work with relative paths

d38c123

Merge branch 'af/8535-cvise' of github.com:noir-lang/noir into af/853…

9a11805

…5-cvise

Merge remote-tracking branch 'origin/master' into af/8535-cvise

77c9f2f

aakoshh disabled auto-merge June 6, 2025 07:45

Mention the minimizer in the AST fuzzer docs

003794d

aakoshh enabled auto-merge June 6, 2025 07:53

aakoshh added this pull request to the merge queue Jun 6, 2025

Merged via the queue into master with commit f0d3d05 Jun 6, 2025
117 checks passed

aakoshh deleted the af/8535-cvise branch June 6, 2025 08:29

AztecBot mentioned this pull request Jun 7, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#14878

Merged

AztecBot mentioned this pull request Jun 10, 2025

chore(next): release 0.88.0 AztecProtocol/aztec-packages#14495

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(fuzz): Tool to minimize Noir programs with `cvise`#8789

chore(fuzz): Tool to minimize Noir programs with `cvise`#8789
aakoshh merged 10 commits intomasterfrom
af/8535-cvise

aakoshh commented Jun 4, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

asterite left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aakoshh commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

github-actions bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

Uh oh!

asterite left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aakoshh commented Jun 4, 2025 •

edited

Loading

github-actions bot left a comment •

edited

Loading