fix(ssa_gen): Do not code gen fetching of empty arrays when initializing the data bus

[vezenovm]

Description

Problem*

Resolves #8398

The snippet in the code gen has this SSA on master:

After Check u128 mul overflow (1):
acir(inline) pure fn main f0 {
  b0(v0: i8, v1: u32, v2: i8, v3: [(i8, i8, u1, u1, [u8; 0]); 2]):
    v5 = array_get v3, index u32 0 -> i8
    v7 = array_get v3, index u32 1 -> i8
    v9 = array_get v3, index u32 2 -> u1
    v11 = array_get v3, index u32 3 -> u1
    v13 = array_get v3, index u32 4 -> [u8; 0]
    v15 = array_get v3, index u32 5 -> i8
    v17 = array_get v3, index u32 6 -> i8
    v19 = array_get v3, index u32 7 -> u1
    v21 = array_get v3, index u32 8 -> u1
    v23 = array_get v3, index u32 9 -> [u8; 0]
    v24 = make_array [v5, v7, v9, v11, v15, v17, v19, v21] : [Field; 8]
    v25 = make_array [] : [(u1, [u8; 3], [u8; 0], u32); 0]
    return v25
}

Calling any mapping of the data bus after DIE will cause a panic.

Summary*

I now do not attempt to fetch an empty array during DIE. No value is ultimately going to be added to the databus so we should just avoid code gen of empty arrays in the data bus initialization in the first place.

I have added an SSA gen unit test databus_no_dead_param_on_empty_array that matches the SSA from the issue snippet.

Additional Context

The changes are a few lines in compiler/noirc_evaluator/src/ssa/function_builder/data_bus.rs. The majority of the line additions are snapshots and generated tests.

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 6d09fd5	Previous: 9dc9cf6	Ratio
rollup-merge	0.004 s	0.003 s	1.33

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[asterite]

LGTM