feat: let static_assert accept any type for its message by asterite · Pull Request #8322 · noir-lang/noir

asterite · 2025-05-02T15:58:28Z

Description

Problem

Resolves #6884

Summary

At first I didn't know how we could turn any value into a string, but I noticed println can do that. So... I used the same approach here (printable types). If the static assertion is true, all the printable type information added to the SSA is eventually removed by DIE.

Here's a commit that shows the output of static_assert when given a fmtstr as a message: 1c1de88

Additional Context

I made some refactors to be able to reuse some of the logic for decoding a PrintableValueDisplay from foreign call params from the noirc_evaluator crate.

Documentation

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

…message

compiler/noirc_evaluator/src/ssa/opt/assert_constant.rs

compiler/noirc_printable_type/src/lib.rs

tooling/nargo/src/foreign_calls/mod.rs

noir_stdlib/src/lib.nr

compiler/noirc_printable_type/src/lib.rs

vezenovm

I had not done a full review and accidentally approved but it doesn't seem to be letting me dismiss my review. I ended up looking over the PR anyway and I am good with the changes after we remove the duplicated decode_value.

…irc_abi

asterite · 2025-05-02T21:09:00Z

Ah, one more thing I'm remembering now. There were three copies of decode_string_value. Now there's one, in noirc_printable_type, but I don't know if that's correct because it has nothing to do with printable types. Should I keep the three copies? It's not that much code (around 10 lines). Otherwise, I don't know where turning a list of field element values into a string by assuming they are bytes could be done so it can be shared with other crates.

github-actions · 2025-05-05T15:39:56Z

🚀 Deployed on https://681a51975dca271f345d8312--noir-docs.netlify.app

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `616cd36`	Previous: `76c9937`	Ratio
`private-kernel-tail`	`1.472` s	`1.14` s	`1.29`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions · 2025-05-06T18:14:58Z

FYI @noir-lang/developerrelations on Noir doc changes.

Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: always type-check turbofish, and error when it's not allowed (noir-lang/noir#8437) chore: Release Noir(1.0.0-beta.5) (noir-lang/noir#7955) feat(greybox_fuzzer): Parallel fuzz tests (noir-lang/noir#8432) fix(ssa): Mislabeled instructions with side effects in EnableSideEffectsIf removal pass (noir-lang/noir#8355) feat: SSA pass impact report (noir-lang/noir#8393) chore: bump external pinned commits (noir-lang/noir#8433) chore: separate benchmarking from github actions more (noir-lang/noir#7943) chore(fuzz): Break up the AST fuzzer `compare` module (noir-lang/noir#8431) chore(fuzz): Rename `init_vs_final` to `min_vs_full` (noir-lang/noir#8430) fix!: error on tuple mismatch (noir-lang/noir#8424) chore: bump external pinned commits (noir-lang/noir#8429) chore(acir): Test whether the predicate has an effect on slice intrinsics (noir-lang/noir#8421) feat(ssa): Mark transitively dead parameters during DIE (noir-lang/noir#8254) fix(ssa_gen): Do not code gen fetching of empty arrays when initializing the data bus (noir-lang/noir#8426) chore: remove `.aztec-sync-commit` (noir-lang/noir#8415) chore(test): Add more unit tests for `inline_functions_with_at_most_one_instruction` (noir-lang/noir#8418) chore: add minor docs for interpreter (noir-lang/noir#8397) fix: print slice composite types surrounded by parentheses (noir-lang/noir#8412) feat: Skip SSA passes that contain any of the given messages (noir-lang/noir#8416) fix: disable range constraints using the predicate (noir-lang/noir#8396) chore: bumping external libraries (noir-lang/noir#8406) chore: redo typo PR by shystrui1199 (noir-lang/noir#8405) feat(test): add `nargo_fuzz_target` (noir-lang/noir#8308) fix: allow names to collide in the values/types namespaces (noir-lang/noir#8286) fix: Fix sequencing of side-effects in lvalue (noir-lang/noir#8384) feat(greybox_fuzzer): Maximum executions parameter added (noir-lang/noir#8390) fix: warn on and discard unreachable statements after break and continue (noir-lang/noir#8382) fix: add handling for u128 infix ops in interpreter (noir-lang/noir#8392) chore: move acirgen tests into separate file (noir-lang/noir#8376) feat(fuzz): initial version of comptime vs brillig target for AST fuzzer (noir-lang/noir#8335) chore: apply lints to `ast_fuzzer` (noir-lang/noir#8386) chore: add note on AI generated PRs in `CONTRIBUTING.md` (noir-lang/noir#8385) chore: document flattening pass (noir-lang/noir#8312) fix: comptime shift-right overflow is zero (noir-lang/noir#8380) feat: let static_assert accept any type for its message (noir-lang/noir#8322) fix(expand): output safety comment before statements (noir-lang/noir#8378) chore: avoid need to rebuild after running tests (noir-lang/noir#8379) chore: bump dependencies (noir-lang/noir#8372) chore: Add GITHUB_TOKEN to cross build (noir-lang/noir#8370) chore: redo typo PR by GarmashAlex (noir-lang/noir#8364) chore: remove unsafe code from greybox fuzzer (noir-lang/noir#8315) feat: add `--fuzz-timeout` to `nargo test` options (noir-lang/noir#8326) chore: bump external pinned commits (noir-lang/noir#8334) fix(expand): try to use "Self" in function calls (noir-lang/noir#8353) fix: Fix evaluation order of assignments with side-effects in their rhs (noir-lang/noir#8342) fix: let comptime Field value carry the field's sign (noir-lang/noir#8343) fix: Ordering of items in callstacks (noir-lang/noir#8338) chore: add snapshosts for nargo expand tests (noir-lang/noir#8318) fix(ownership): Clone global arrays (noir-lang/noir#8328) chore: Replace all SSA interpreter panics with error variants (noir-lang/noir#8311) feat: Metamorphic AST fuzzing (noir-lang/noir#8299) fix: fix some Display implementations for AST nodes (noir-lang/noir#8316) chore: remove leftover file (noir-lang/noir#8313) fix: uses non-zero points with ec-add-unsafe (noir-lang/noir#8248) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

asterite added 2 commits May 2, 2025 12:52

feat: let static_assert accept any type for its message

9441447

Fix the comptime part

1c6396a

asterite marked this pull request as draft May 2, 2025 15:58

asterite added 3 commits May 2, 2025 14:29

Don't use indirect call

f8e8f43

Update snaphosts

6e7ac02

Add a test program that proves fmtstr can be used in static_assert's …

1c1de88

…message

asterite requested a review from a team May 2, 2025 17:53

asterite added 6 commits May 2, 2025 15:38

Move decode_value and decode_string_value to the printable types crate

edd5618

Move try_from_params to printable types crate

294b2b1

Let try_from_params belong to PrintableValueDisplay

e1cbe46

Rename an error variant

7e79134

Empty body of built-in function

f92c457

Use the same error name

e728f66

asterite marked this pull request as ready for review May 2, 2025 19:02

Fix docs

d1b4b74

michaeljklein suggested changes May 2, 2025

View reviewed changes

Update snapshots

631904e

vezenovm approved these changes May 2, 2025

View reviewed changes

compiler/noirc_printable_type/src/lib.rs Outdated Show resolved Hide resolved

vezenovm reviewed May 2, 2025

View reviewed changes

decode_value -> decode_printable_value, and remove re-exports from no…

a5daeb6

…irc_abi

asterite added 5 commits May 2, 2025 18:22

Merge branch 'master' into ab/static-assert-any-message

72d69eb

Update snapshosts after merge

4dbd983

Always compute message

d20c534

panic instead of returning runtime error

8748ff7

Docs

f0dba0a

github-actions bot added the documentation Improvements or additions to documentation label May 5, 2025

asterite requested a review from michaeljklein May 5, 2025 19:57

Show message when predicate is dynamic

df4e5b4

Update snapshosts

616cd36

github-actions bot reviewed May 6, 2025

View reviewed changes

Update stderr.txt

6307e36

michaeljklein approved these changes May 6, 2025

View reviewed changes

asterite added this pull request to the merge queue May 6, 2025

Merged via the queue into master with commit cc3fa6f May 6, 2025
116 checks passed

asterite deleted the ab/static-assert-any-message branch May 6, 2025 19:30

noirwhal mentioned this pull request May 6, 2025

chore: Release Noir(1.0.0-beta.5) #7955

Merged

AztecBot mentioned this pull request May 7, 2025

chore: Bump Noir reference AztecProtocol/aztec-packages#14055

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: let static_assert accept any type for its message#8322

feat: let static_assert accept any type for its message#8322
asterite merged 22 commits intomasterfrom
ab/static-assert-any-message

asterite commented May 2, 2025 •

edited by Savio-Sou

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vezenovm left a comment

Uh oh!

asterite commented May 2, 2025

Uh oh!

github-actions bot commented May 5, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

asterite commented May 2, 2025 • edited by Savio-Sou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Summary

Additional Context

Documentation

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vezenovm left a comment

Choose a reason for hiding this comment

Uh oh!

asterite commented May 2, 2025

Uh oh!

github-actions bot commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

github-actions bot commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

asterite commented May 2, 2025 •

edited by Savio-Sou

Loading

github-actions bot commented May 5, 2025 •

edited

Loading