chore: updated "HirFunction::unsafe_from_expr" to "HirFunction::unchecked_from_expr"

[DreamerChaserHAH]

As per this issue #812

Renamed

HirFunction::unsafe_from_expr
You can use the search function in your IDE to search for unsafe_from_expr, I cannot find it elsewhere only three places

to
HirFunction::unchecked_from_expr

Related issue(s)

Resolves #812

Description

Summary of changes

Changes 1

crates\noirc_frontend\src\hir\resolution\resolver.rs line number 299
from
HirFunction::unsafe_from_expr(expr_id)
to
HirFunction::unchecked_from_expr(expr_id)

Changes 2

crates\noirc_frontend\src\hir\type_check\mod.rs line number 137
from
let func = HirFunction::unsafe_from_expr(expr_id);
to
let func = HirFunction::unchecked_from_expr(expr_id);

Changes 3

Added a comment in crates\noirc_frontend\src\hir_def\function.rs line number: 21

Changes 4

crates\noirc_frontend\src\hir_def\function.rs line number 23/24
from
pub const fn unsafe_from_expr(expr_id: ExprId) -> HirFunction {
to
pub const fn unchecked_from_expr(expr_id: ExprId) -> HirFunction {

Basically just changing every unsafe_from_expr to unchecked_from_expr, nothing else has been changed

Dependency additions / changes

Test additions / changes

Checklist

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt with default settings.
• I have linked this PR to the issue(s) that it resolves.
• I have reviewed the changes on GitHub, line by line.
• I have ensured all changes are covered in the description.
• This PR requires documentation updates when merged.

Additional context

[kevaundray]

Thanks for resolving this, looks good overall. Left a comment.

[kevaundray]

LGTM