chore(ssa): rename impl method to follow Rust guideline#782
Merged
kevaundray merged 7 commits intomasterfrom Feb 11, 2023
Merged
chore(ssa): rename impl method to follow Rust guideline#782kevaundray merged 7 commits intomasterfrom
kevaundray merged 7 commits intomasterfrom
Conversation
ssa: change `get_mut_x()` to `x_mut`
guipublic
previously requested changes
Feb 9, 2023
Contributor
guipublic
left a comment
guipublic
left a comment
There was a problem hiding this comment.
It's fine, but could you also fix the few spelling issues reported by the CI?
Contributor
Author
Those have been fixed in a PR that we merged a few hours ago, I've rebased the branch to pull in those changes |
jfecher
previously approved these changes
Feb 9, 2023
auto-merge was automatically disabled
February 9, 2023 20:19
Merge queue setting changed
jfecher
previously approved these changes
Feb 10, 2023
kevaundray
dismissed
guipublic’s stale review
spellchecker has been fixed in another PR
TomAFrench
added a commit
that referenced
this pull request
Feb 14, 2023
* master: (28 commits) chore(ci): Add release token to enable runs against release PR (#840) feat(ssa): array sort (#754) chore: update readme (#811) chore: fix clippy (#825) chore: remove stale comment on HirFunction.unchecked_from_expr (#827) chore: Getter naming refactor (#803) chore: updated "HirFunction::unsafe_from_expr" to "HirFunction::unchecked_from_expr" (#823) chore: Forbid unsafe code (#824) chore: Follow rust naming convention (#801) feat(ci): Add concurrency group for rust workflow (#806) chore(ssa): rename impl method to follow Rust guideline (#782) fix(nargo): `nargo test` now only runs test functions defined in the current module (#805) chore(nargo): Remove outdated error message when Prover/Verifier.toml is missing (#807) chore(ssa): rename codegen to ssa_gen + reorg of `Value` struct (#797) chore(nargo): abstract paths from nargo's working directory (#761) chore(ci): Rename workflows (#804) feat: Impls with generics (#798) chore(ssa): Add doc comments on `Opcode` struct (#778) fix: operators issuing type errors when used with matching integer types arising from generic code (#789) chore(nargo)!: bump MSRV to 1.66.0 (#799) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Related to #780
Resolves #
Description
Summary of changes
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Additional context