chore(benchmark): Improve noir msm benchmark#7390
Merged
sirasistant merged 3 commits intomasterfrom Feb 19, 2025
Merged
Conversation
sirasistant
commented
Feb 14, 2025
sirasistant
commented
Feb 14, 2025
sirasistant
commented
Feb 14, 2025
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Author
|
Let me update the scalars to some random fields... |
Contributor
You will want to submit as a separate PR so we can see the diff here. We could have a couple tests with different inputs. |
Contributor
Author
|
Is there a mechanism to have multiple Prover.tomls for benchmarking? |
Contributor
Author
|
If not I think it's better to have this benchmark with some scalars of different sizes |
Contributor
Aside a workspace, no unfortunately. A workspace is the mechanism we use for generating the report from |
sirasistant
changed the title
Contributor
Yeah let's just update this benchmark for now. |
Contributor
Author
|
Now it has more realistic numbers for 5 scalars :D |
vezenovm
approved these changes
Feb 18, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 19, 2025
chore!: make `ResolverError::OracleMarkedAsConstrained` into a full error (noir-lang/noir#7426) chore: simplify reports (noir-lang/noir#7421) fix: do not discard negative sign from field literals in comptime interpreter (noir-lang/noir#7439) chore: bump aztec-packages commit (noir-lang/noir#7441) fix: require loop/for/while body to be unit (noir-lang/noir#7437) feat: simplify assertions that squared values are equal to zero (noir-lang/noir#7432) chore(benchmark): Improve noir msm benchmark (noir-lang/noir#7390) chore: Add SSA security checks description (noir-lang/noir#7366)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 19, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat(cli): add noir-execute binary (noir-lang/noir#7384) chore!: make `ResolverError::OracleMarkedAsConstrained` into a full error (noir-lang/noir#7426) chore: simplify reports (noir-lang/noir#7421) fix: do not discard negative sign from field literals in comptime interpreter (noir-lang/noir#7439) chore: bump aztec-packages commit (noir-lang/noir#7441) fix: require loop/for/while body to be unit (noir-lang/noir#7437) feat: simplify assertions that squared values are equal to zero (noir-lang/noir#7432) chore(benchmark): Improve noir msm benchmark (noir-lang/noir#7390) chore: Add SSA security checks description (noir-lang/noir#7366) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Improves the MSM benchmark, by fixing some bugs and using double then add which minimizes work inside the loop.
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.