feat(cli): add noir-execute binary#7384
Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 2672478 | Previous: d0d04e8 | Ratio |
|---|---|---|---|
AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
66 s |
51 s |
1.29 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
Can you also add some tests for this showing the usage of the CLI? |
I created a separate story for that: #7382 |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 2672478 | Previous: d0d04e8 | Ratio |
|---|---|---|---|
regression_4709 |
0.889 s |
0.725 s |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
Added a test showing the usage of the transcript in #7417 |
chore!: make `ResolverError::OracleMarkedAsConstrained` into a full error (noir-lang/noir#7426) chore: simplify reports (noir-lang/noir#7421) fix: do not discard negative sign from field literals in comptime interpreter (noir-lang/noir#7439) chore: bump aztec-packages commit (noir-lang/noir#7441) fix: require loop/for/while body to be unit (noir-lang/noir#7437) feat: simplify assertions that squared values are equal to zero (noir-lang/noir#7432) chore(benchmark): Improve noir msm benchmark (noir-lang/noir#7390) chore: Add SSA security checks description (noir-lang/noir#7366)
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat(cli): add noir-execute binary (noir-lang/noir#7384) chore!: make `ResolverError::OracleMarkedAsConstrained` into a full error (noir-lang/noir#7426) chore: simplify reports (noir-lang/noir#7421) fix: do not discard negative sign from field literals in comptime interpreter (noir-lang/noir#7439) chore: bump aztec-packages commit (noir-lang/noir#7441) fix: require loop/for/while body to be unit (noir-lang/noir#7437) feat: simplify assertions that squared values are equal to zero (noir-lang/noir#7432) chore(benchmark): Improve noir msm benchmark (noir-lang/noir#7390) chore: Add SSA security checks description (noir-lang/noir#7366) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch>
* master: (89 commits) chore: bump external pinned commits (#7472) chore: remove `disable_macros` compile option (#7468) chore(ci): add workflow to automate bumping aztec-packages commit (#7465) chore: Release Noir(1.0.0-beta.3) (#7346) chore(ci): Missing dash in profiler command argument (#7467) feat(experimental): show macro errors where they happen (#7333) feat: optimize FieldElement::num_bits (#7147) chore(profiler): Docs on profiler command and more complete error reporting (#7436) feat(ci): Release noir-inspector in binaries (#7464) chore(docs): Noir Profiler external documentation (#7457) feat(ci): Publish binaries for noir-profiler (#7443) chore: Copy #7387 docs into v1.0.0-beta.2 versioned_docs (#7458) fix: prevent incorrect ACIRgen caused by noop truncations (#7456) feat: add native `u128` type (#7301) chore: standardize that doc comments on top of statements and expression are allowed but warn (#7450) fix: don't let nargo fmt produce multiple trailing newlines (#7444) feat(cli): add noir-execute binary (#7384) chore!: make `ResolverError::OracleMarkedAsConstrained` into a full error (#7426) chore: simplify reports (#7421) fix: do not discard negative sign from field literals in comptime interpreter (#7439) ...
Description
Problem*
Resolves #7383
Summary*
Created a new
tooling/artifact_clicrate which is both a library and a binary:fsutilities to read inputs and write witnesses; this is currently used by theacvm_clito remove some duplication, but could be used bynargo, theprofilerand theinspector(done in chore(cli): Usenoir_artifact_cli::fsto read artifacts #7391)noir-executebinary which reads in a contract or a binary artefact and executes the circuit, similar tonargo execute; this could be invoked fromnargoto remove some duplication (done in chore(cli): Forwardnargo executetonoir_artifact_cli#7406)Left for follow-up PRs:
Additional Context
Testing
Options
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.