chore: box ExprValue in Value enum#7388
Merged
TomAFrench merged 4 commits intomasterfrom Feb 14, 2025
Merged
Conversation
Member
Author
|
This causes an appreciable drop in the test suite benchmarks. |
Collaborator
|
Also doing |
asterite
approved these changes
Feb 14, 2025
Collaborator
How do you check this? Do you manually check the times on the CI run? |
Member
Author
|
I'm just looking in the github actions output when it's uploading the metrics: https://github.com/noir-lang/noir/actions/runs/13334702437/job/37247801035?pr=7388 I can then check against https://noir-lang.github.io/noir/dev/bench/ to see if they line up or not. I think I can get the comments to show up if we apply a label to the PR however which will make this easier. |
5 tasks
5 tasks
TomAFrench
added a commit
that referenced
this pull request
Feb 14, 2025
…rom-brillig * master: chore: allow opting in to displaying benchmark comments (#7399) chore: box `ExprValue` in `Value` enum (#7388) chore: pull out refactored methods from u128 branch (#7385) feat: require safety comments instead of safety doc comments (#7295) fix(ssa): Do not deduplicate division by a zero constant (#7393) chore: document traits required to be in scope (#7387) fix: field zero division in brillig (#7386) chore: box `ParserError`s in `InterpreterError` (#7373) chore: remove unnecessary dereferencing within brillig vm (#7375) fix: give "correct" error when trying to use AsTraitPath (#7360) chore: avoid u128s in brillig memory (#7363) chore: update docs about integer overflows (#7370) fix!: Only decrement the counter of an array if its address has not changed (#7297) fix: let LSP read `noirfmt.toml` for formatting files (#7355) chore: deprecate keccak256 (#7361) feat: `FunctionDefinition::as_typed_expr` (#7358) feat(performance): Check sub operations against induction variables (#7356) chore: avoid doing all brillig integer arithmetic on u128s (#7357)
TomAFrench
added a commit
that referenced
this pull request
Feb 14, 2025
* master: chore: allow opting in to displaying benchmark comments (#7399) chore: box `ExprValue` in `Value` enum (#7388) chore: pull out refactored methods from u128 branch (#7385) feat: require safety comments instead of safety doc comments (#7295) fix(ssa): Do not deduplicate division by a zero constant (#7393) chore: document traits required to be in scope (#7387) fix: field zero division in brillig (#7386) chore: box `ParserError`s in `InterpreterError` (#7373) chore: remove unnecessary dereferencing within brillig vm (#7375)
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 15, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 16, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 16, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 17, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 17, 2025
chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 17, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: format global attributes (noir-lang/noir#7401) chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch>
AztecBot
added a commit
to AztecProtocol/aztec-nr
that referenced
this pull request
Feb 18, 2025
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: format global attributes (noir-lang/noir#7401) chore: box `Closure` in `comptime::Value` enum (noir-lang/noir#7400) chore: allow opting in to displaying benchmark comments (noir-lang/noir#7399) chore: box `ExprValue` in `Value` enum (noir-lang/noir#7388) chore: pull out refactored methods from u128 branch (noir-lang/noir#7385) feat: require safety comments instead of safety doc comments (noir-lang/noir#7295) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Followup to #7373
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.