feat: FunctionDefinition::as_typed_expr

[asterite]

Description

Problem

Resolves #7314
Resolves #7315

Will make AztecProtocol/aztec-packages#11863 possible.

Summary

First adds FunctionDefinition::as_typed_expr, which does the same logic of type-checking the function and turning it into an ExprId.

Then, allows unquoting TypedExpr in a way that preserves the underlying ExprId.

Additional Context

In the code there's a let generics = None;. Those would be the generics resulting from turbofish on the function. Eventually we could add a as_typed_expr_with_turbofish or similar that takes a [Type] for for the generics... if really needed.

Documentation

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

🚀 Deployed on https://67ad0f17501d9455b9b5de17--noir-docs.netlify.app

[michaeljklein]

Please add a couple more tests, e.g.

unconstrained fn foo<T, let N: u32>(xs: [T; N]) -> u32 {
    xs.len()
}

comptime fn bar<T, U, let N: u32>(xs_ys: ([T; N], U)) -> u32 {
    let (xs, ys) = xs_ys;
    xs.len()
}

And regression tests for the original cases.

Otherwise it LGTM

[asterite]

Do you mean getting a reference to foo and bar, converting them to typed exprs and unquoting them?

[asterite]

And regression tests for the original cases.

What would the original cases be?

[michaeljklein]

Do you mean getting a reference to foo and bar, converting them to typed exprs and unquoting them?

Yes

What would the original cases be?

Just the one case from #7315:

comptime fn foo(f: TypedExpr) -> Quoted {
    quote {
        $f()
    }
}

fn bar() -> Field {
    1
}

fn main() {
    let x: Field = comptime {
        let bar_q = quote {
            bar
        };
        foo(bar_q.as_expr().unwrap().resolve(Option::none()))
    };
    assert(x == 1);
}

[asterite]

Done!

[github-actions]

FYI @noir-lang/developerrelations on Noir doc changes.