Conversation
|
Why are we moving barretenberg repo again? |
The repo that was originally being referenced was renamed, so we needed to rename the url in the dependency |
|
Could we have a master aztec backend that works instead of specifying a revision? |
We were always moving barretenberg repo to reflect the aztec-connect changes (https://github.com/noir-lang/aztec-connect/tree/kw/noir-dsl). However, this barretenberg repo is not yet ready to be used as the main The |
jfecher
left a comment
There was a problem hiding this comment.
Looks fine to me. We can merge once @guipublic's concerns are addressed
To be clear, the problem was not that the branch changed, the repo itself got renamed, so even with a revision it would have still caused problems |
|
Let's merge as this does not change any behaviour. @guipublic if you have further concerns, we can discuss in a separate issue, since this is stopping the CI from passing |
* master: update backend ref (noir-lang#561) Tell `clap` to use help text when no subcommand (noir-lang#559)
* master: Split `util` module from noirc_frontend into new crate (noir-lang#560) update backend ref (noir-lang#561) Tell `clap` to use help text when no subcommand (noir-lang#559) moving noirup and build files out to separate repositories (noir-lang#557) Make `noirup` pull latest nightly build by default (noir-lang#470)
* master: Update workflow to run on 20.04 to fix CI (noir-lang#565) Split `util` module from noirc_frontend into new crate (noir-lang#560) update backend ref (noir-lang#561) Tell `clap` to use help text when no subcommand (noir-lang#559) moving noirup and build files out to separate repositories (noir-lang#557) Make `noirup` pull latest nightly build by default (noir-lang#470) Handle predicate operator during inlining (noir-lang#544) Add gitattributes (noir-lang#541)
Related issue(s)
Resolves this comment
Description
The barretenberg repo was renamed which causes the Noir build to fail on the CI as the
aztec_backendreference innargo'sCargo.tomlfile referenced the wrong repo. We are in the process of moving barretenberg to a new repo. I made a temporary PR that can be found here that will be used until we fix the issues from the barretenberg migration and can move to the updated repository.Summary of changes
(Describe the changes in this PR. Point out breaking changes if any.)
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)