Skip to content

update backend ref#561

Merged
kevaundray merged 1 commit intomasterfrom
mv/update-backend-ref
Dec 6, 2022
Merged

update backend ref#561
kevaundray merged 1 commit intomasterfrom
mv/update-backend-ref

Conversation

@vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Dec 6, 2022

Related issue(s)

Resolves this comment

Description

The barretenberg repo was renamed which causes the Noir build to fail on the CI as the aztec_backend reference in nargo's Cargo.toml file referenced the wrong repo. We are in the process of moving barretenberg to a new repo. I made a temporary PR that can be found here that will be used until we fix the issues from the barretenberg migration and can move to the updated repository.

Summary of changes

(Describe the changes in this PR. Point out breaking changes if any.)

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@guipublic
Copy link
Contributor

Why are we moving barretenberg repo again?

@kevaundray
Copy link
Contributor

Why are we moving barretenberg repo again?

The repo that was originally being referenced was renamed, so we needed to rename the url in the dependency

@guipublic
Copy link
Contributor

Could we have a master aztec backend that works instead of specifying a revision?

@vezenovm
Copy link
Contributor Author

vezenovm commented Dec 6, 2022

Why are we moving barretenberg repo again?

Could we have a master aztec backend that works instead of specifying a revision?

We were always moving barretenberg repo to reflect the aztec-connect changes (https://github.com/noir-lang/aztec-connect/tree/kw/noir-dsl). However, this barretenberg repo is not yet ready to be used as the main aztec_backend commit. (which I am fixing up). The old repo that was still being referenced on Noir master was renamed so we need to rename the url as @kevaundray said in his comment above.

The aztec_backend master branch currently references the noir-lang/aztec-connect repo (https://github.com/noir-lang/aztec_backend), and once we get Noir fully working with the changes from this branch we can update Noir to reference this version of the aztec_backend, which will be the new aztec_backend master branch. This temporary PR noir-lang/acvm-backend-barretenberg#25 is being used rather than the newly updated barretenberg until then. We are specifying a revision just so that the entire Noir build is not failing until the master aztec backend is fixed.

@vezenovm vezenovm marked this pull request as ready for review December 6, 2022 18:10
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. We can merge once @guipublic's concerns are addressed

@kevaundray
Copy link
Contributor

Could we have a master aztec backend that works instead of specifying a revision?

To be clear, the problem was not that the branch changed, the repo itself got renamed, so even with a revision it would have still caused problems

@kevaundray
Copy link
Contributor

Let's merge as this does not change any behaviour. @guipublic if you have further concerns, we can discuss in a separate issue, since this is stopping the CI from passing

@kevaundray kevaundray merged commit 6048e49 into master Dec 6, 2022
@kevaundray kevaundray deleted the mv/update-backend-ref branch December 6, 2022 18:55
TomAFrench added a commit to TomAFrench/noir that referenced this pull request Dec 6, 2022
* master:
  update backend ref (noir-lang#561)
  Tell `clap` to use help text when no subcommand (noir-lang#559)
TomAFrench added a commit to TomAFrench/noir that referenced this pull request Dec 6, 2022
* master:
  Split `util` module from noirc_frontend into new crate (noir-lang#560)
  update backend ref (noir-lang#561)
  Tell `clap` to use help text when no subcommand (noir-lang#559)
  moving noirup and build files out to separate repositories (noir-lang#557)
  Make `noirup` pull latest nightly build by default (noir-lang#470)
TomAFrench added a commit to TomAFrench/noir that referenced this pull request Dec 8, 2022
* master:
  Update workflow to run on 20.04 to fix CI (noir-lang#565)
  Split `util` module from noirc_frontend into new crate (noir-lang#560)
  update backend ref (noir-lang#561)
  Tell `clap` to use help text when no subcommand (noir-lang#559)
  moving noirup and build files out to separate repositories (noir-lang#557)
  Make `noirup` pull latest nightly build by default (noir-lang#470)
  Handle predicate operator during inlining (noir-lang#544)
  Add gitattributes (noir-lang#541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants