Make noirup pull latest nightly build by default#470
Merged
kobyhallx merged 7 commits intonoir-lang:masterfrom Dec 5, 2022
Merged
Make noirup pull latest nightly build by default#470kobyhallx merged 7 commits intonoir-lang:masterfrom
noirup pull latest nightly build by default#470kobyhallx merged 7 commits intonoir-lang:masterfrom
Conversation
Member
Author
|
Keep in mind that there's currently no build for |
Member
Author
|
Looks like we're not unpacking the std lib properly, testing worked as I already had an existing copy. |
jfecher
reviewed
Nov 28, 2022
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
Pinging @kobyhallx for tooling visibility
kobyhallx
suggested changes
Dec 1, 2022
kobyhallx
approved these changes
Dec 5, 2022
Contributor
|
Merging with intent to move noirup into its own repository. |
5 tasks
TomAFrench
added a commit
to TomAFrench/noir
that referenced
this pull request
Dec 6, 2022
* master: Split `util` module from noirc_frontend into new crate (noir-lang#560) update backend ref (noir-lang#561) Tell `clap` to use help text when no subcommand (noir-lang#559) moving noirup and build files out to separate repositories (noir-lang#557) Make `noirup` pull latest nightly build by default (noir-lang#470)
TomAFrench
added a commit
to TomAFrench/noir
that referenced
this pull request
Dec 8, 2022
* master: Update workflow to run on 20.04 to fix CI (noir-lang#565) Split `util` module from noirc_frontend into new crate (noir-lang#560) update backend ref (noir-lang#561) Tell `clap` to use help text when no subcommand (noir-lang#559) moving noirup and build files out to separate repositories (noir-lang#557) Make `noirup` pull latest nightly build by default (noir-lang#470) Handle predicate operator during inlining (noir-lang#544) Add gitattributes (noir-lang#541)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
#225 Releases don't contain binaries anymore
Description
Summary of changes
noirupcurrently always buildsnargofrom source due to #225. As we move towards publishing binaries we can havenoiruptake advantage of this to pull the nightly build.This PR makes this the default behaviour for
noirup. The current behaviour of building locally is still available throughnoirup -b master.I haven't tested this yet as there are currently no binaries to download but we can test tomorrow. The url of the tarball to download will almost definitely needs to be tweaked.Tested on linux.Dependency additions / changes
N/A
Test additions / changes
N/A
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)