fix: Implement interpretation of member access on tuples#5311
Merged
jfecher merged 6 commits intojf/type-def-apifrom Jun 24, 2024
Merged
fix: Implement interpretation of member access on tuples#5311jfecher merged 6 commits intojf/type-def-apifrom
jfecher merged 6 commits intojf/type-def-apifrom
Conversation
TomAFrench
approved these changes
Jun 22, 2024
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
michaeljklein
approved these changes
Jun 24, 2024
# Description ## Problem\* ## Summary\* Implements `slice_push_back` in the comptime interpreter. This was needed in the vertical slice example to build a slice of quoted fields for the type in the impl. ## Additional Context With this a slightly modified version of the vertical slice code now runs. Notably: - Generic functions do not work, so a `map` function like in the original cannot be used - An annotation function can return a quoted impl, but the impl isn't actually inserted into the program yet. So the derived impl does nothing currently. ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Fixes an issue in the interpreter where the interpreter would error for member access expressions on tuples. This prevented e.g.
my_tuple.0.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.