Skip to content

feat: Implement slice_push_back in the comptime interpreter#5312

Merged
jfecher merged 5 commits intojf/fix-interpreter-member-accessfrom
jf/interpreter-push-back
Jun 24, 2024
Merged

feat: Implement slice_push_back in the comptime interpreter#5312
jfecher merged 5 commits intojf/fix-interpreter-member-accessfrom
jf/interpreter-push-back

Conversation

@jfecher
Copy link
Contributor

@jfecher jfecher commented Jun 21, 2024

Description

Problem*

Summary*

Implements slice_push_back in the comptime interpreter. This was needed in the vertical slice example to build a slice of quoted fields for the type in the impl.

Additional Context

With this a slightly modified version of the vertical slice code now runs. Notably:

  • Generic functions do not work, so a map function like in the original cannot be used
  • An annotation function can return a quoted impl, but the impl isn't actually inserted into the program yet. So the derived impl does nothing currently.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher requested a review from a team June 21, 2024 20:04
@jfecher jfecher merged commit 2825fef into jf/fix-interpreter-member-access Jun 24, 2024
@jfecher jfecher deleted the jf/interpreter-push-back branch June 24, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants