chore: perform dead instruction elimination through std::as_witness#5123
Merged
TomAFrench merged 5 commits intomasterfrom May 28, 2024
Merged
chore: perform dead instruction elimination through std::as_witness#5123TomAFrench merged 5 commits intomasterfrom
std::as_witness#5123TomAFrench merged 5 commits intomasterfrom
Conversation
TomAFrench
commented
May 28, 2024
TomAFrench
commented
May 28, 2024
vezenovm
approved these changes
May 28, 2024
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 28, 2024
AztecBot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 28, 2024
…ir#5109) feat: Sync from aztec-packages (noir-lang/noir#5125) chore: remove warnings field from `DebugArtifact` (noir-lang/noir#5118) feat: make ACVM generic across fields (noir-lang/noir#5114) fix: Auto dereference trait methods in the elaborator (noir-lang/noir#5124) chore: perform dead instruction elimination through `std::as_witness` (noir-lang/noir#5123)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 28, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: deduplicate `ReturnConstant` warning (noir-lang/noir#5109) feat: Sync from aztec-packages (noir-lang/noir#5125) chore: remove warnings field from `DebugArtifact` (noir-lang/noir#5118) feat: make ACVM generic across fields (noir-lang/noir#5114) fix: Auto dereference trait methods in the elaborator (noir-lang/noir#5124) chore: perform dead instruction elimination through `std::as_witness` (noir-lang/noir#5123) END_COMMIT_OVERRIDE --------- Co-authored-by: TomAFrench <tom@tomfren.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR adds handling for
std::as_witnessin dead instruction elimination. i.e. if we're asking for an SSA value to be assigned to a witness when that value would not otherwise be represented in the ACIR then we can remove it.This issue can be seen in #5122 where making two calls to the same function with the same inputs and asserting that the outputs are the same results in constraints whereas this can be determined at runtime.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.