chore: abstract away subtractions from OR implementation#3923
Merged
TomAFrench merged 2 commits intomasterfrom Jan 2, 2024
Merged
chore: abstract away subtractions from OR implementation#3923TomAFrench merged 2 commits intomasterfrom
OR implementation#3923TomAFrench merged 2 commits intomasterfrom
Conversation
TomAFrench
changed the title
OR implementation
kevaundray
approved these changes
Jan 2, 2024
TomAFrench
added a commit
that referenced
this pull request
Jan 3, 2024
* master: (48 commits) chore: fix broken links (#3935) chore: updated ACIR documentation and other docs (#3932) chore: rename "syntax" chapter in docs to "concepts" (#3934) fix: checks for cyclic dependencies (#3699) fix(debugger): crash when stepping through locations spanning multiple lines (#3920) chore: abstract away subtractions from `OR` implementation (#3923) chore: fix `should_fail_mismatch` test to use correct pedersen return type (#3927) fix: prevent `Instruction::Constrain`s for non-primitive types (#3916) feat: remove unnecessary predicate from `Lt` instruction (#3922) feat: simplify multiplications by `0` or `1` in ACIR gen (#3924) chore: bump dependency versions (#3925) chore: Update CONTRIBUTING.md (#3921) chore: Optimize goto_definitions for workspace case (#3914) chore: Update index.md (#3911) chore: Update index.md (#3910) chore: Update how-to-recursion.md (#3912) feat: Resolve oracle calls via JSON-RPC (#3902) chore: Update explainer-recursion.md (#3906) chore: remove unnecessary dependency (#3901) chore: improve package.json metadata (#3900) ...
TomAFrench
added a commit
that referenced
this pull request
Jan 4, 2024
* master: (30 commits) fix: handle multiple imports in the same file (#3903) feat: add foreign call support to `noir_codegen` functions (#3933) feat: Implement Operator Overloading (#3931) chore: fix casing on `InternalError::Unexpected` (#3937) chore: add test case for brillig array equality assertion (#3936) feat(lsp): goto struct member inside Impl method (#3918) chore: fix broken links (#3935) chore: updated ACIR documentation and other docs (#3932) chore: rename "syntax" chapter in docs to "concepts" (#3934) fix: checks for cyclic dependencies (#3699) fix(debugger): crash when stepping through locations spanning multiple lines (#3920) chore: abstract away subtractions from `OR` implementation (#3923) chore: fix `should_fail_mismatch` test to use correct pedersen return type (#3927) fix: prevent `Instruction::Constrain`s for non-primitive types (#3916) feat: remove unnecessary predicate from `Lt` instruction (#3922) feat: simplify multiplications by `0` or `1` in ACIR gen (#3924) chore: bump dependency versions (#3925) chore: Update CONTRIBUTING.md (#3921) chore: Optimize goto_definitions for workspace case (#3914) chore: Update index.md (#3911) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This is just a small cleanup so that we can think in terms of logic operators rather than subtractions here.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.