feat: Resolve oracle calls via JSON-RPC#3902
Merged
sirasistant merged 8 commits intomasterfrom Dec 22, 2023
Merged
Conversation
sirasistant
commented
Dec 21, 2023
Contributor
|
deny.toml is failing because of CC0 license -- we already rely on a CC0 license, so I don't think this is a blocker -- see note in deny.toml as to why we conservatively deny CC0 |
kevaundray
reviewed
Dec 21, 2023
kevaundray
approved these changes
Dec 21, 2023
Contributor
kevaundray
left a comment
There was a problem hiding this comment.
LGTM - was cargo update ran on this branch? most changes are coming from the cargo.lock
Contributor
Author
Nope, but i'll reset cargo lock to master and run cargo build again just to make sure |
TomAFrench
added a commit
that referenced
this pull request
Dec 28, 2023
* master: chore: Optimize goto_definitions for workspace case (#3914) chore: Update index.md (#3911) chore: Update index.md (#3910) chore: Update how-to-recursion.md (#3912) feat: Resolve oracle calls via JSON-RPC (#3902) chore: Update explainer-recursion.md (#3906) chore: remove unnecessary dependency (#3901) chore: improve package.json metadata (#3900) feat: prefer `AcirContext`-native methods for performing logic operations (#3898) feat: optimize logic gate ACIR-gen (#3897) fix: allow abi encoding tuples from JS (#3894) chore: error on cspell issues in docs (#3886)
TomAFrench
added a commit
that referenced
this pull request
Jan 3, 2024
* master: (48 commits) chore: fix broken links (#3935) chore: updated ACIR documentation and other docs (#3932) chore: rename "syntax" chapter in docs to "concepts" (#3934) fix: checks for cyclic dependencies (#3699) fix(debugger): crash when stepping through locations spanning multiple lines (#3920) chore: abstract away subtractions from `OR` implementation (#3923) chore: fix `should_fail_mismatch` test to use correct pedersen return type (#3927) fix: prevent `Instruction::Constrain`s for non-primitive types (#3916) feat: remove unnecessary predicate from `Lt` instruction (#3922) feat: simplify multiplications by `0` or `1` in ACIR gen (#3924) chore: bump dependency versions (#3925) chore: Update CONTRIBUTING.md (#3921) chore: Optimize goto_definitions for workspace case (#3914) chore: Update index.md (#3911) chore: Update index.md (#3910) chore: Update how-to-recursion.md (#3912) feat: Resolve oracle calls via JSON-RPC (#3902) chore: Update explainer-recursion.md (#3906) chore: remove unnecessary dependency (#3901) chore: improve package.json metadata (#3900) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a JSON-RPC client to the DefaultForeignCallExecutor. This allows it to solve unknown oracle calls. The URL to the foreign call executor is an optional argument to nargo execute, nargo test and nargo prove.
Problem*
Resolves #1052
Summary*
Additional Context
An example echo server in typescript
And the corresponding main.nr
Documentation*
Check one:
(We can document this when we evaluate if this solution is enough)
PR Checklist*
cargo fmton default settings.