Skip to content

chore!: Remove add_file and file_reader from FileManager#3762

Merged
kevaundray merged 6 commits intokw/make-fm-read-onlyfrom
kw/remove-add-file-fm
Dec 11, 2023
Merged

chore!: Remove add_file and file_reader from FileManager#3762
kevaundray merged 6 commits intokw/make-fm-read-onlyfrom
kw/remove-add-file-fm

Conversation

@kevaundray
Copy link
Contributor

Description

This removes FileManager from add_file and uses add_file_with_source

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray changed the title chore: Remove add_file from FileManager chore!: Remove add_file from FileManager Dec 11, 2023
@kevaundray kevaundray changed the title chore!: Remove add_file from FileManager chore!: Remove add_file from FileManager Dec 11, 2023
@kevaundray kevaundray changed the title chore!: Remove add_file from FileManager chore!: Remove add_file and file_reader from FileManager Dec 11, 2023
…path is canonical and the other which adds the root and canonicalizes (#3763)

# Description

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning for this change?

@kevaundray
Copy link
Contributor Author

What is the reasoning for this change?

This is a follow-up to #3760 -- I made it a separate PR just so that I could modularise the changes being made, but its intended to be merged into 3760 and then 3760 can be seen as one PR.

This PR essentially removes add_file which is no longer being used because of 3760.

@kevaundray kevaundray marked this pull request as ready for review December 11, 2023 17:38
@kevaundray kevaundray merged commit 5b867d5 into kw/make-fm-read-only Dec 11, 2023
@kevaundray kevaundray deleted the kw/remove-add-file-fm branch December 11, 2023 17:38
@kevaundray
Copy link
Contributor Author

What is the reasoning for this change?

This is a follow-up to #3760 -- I made it a separate PR just so that I could modularise the changes being made, but its intended to be merged into 3760 and then 3760 can be seen as one PR.

This PR essentially removes add_file which is no longer being used because of 3760.

What is the reasoning for this change?

This is a follow-up to #3760 -- I made it a separate PR just so that I could modularise the changes being made, but its intended to be merged into 3760 and then 3760 can be seen as one PR.

This PR essentially removes add_file which is no longer being used because of 3760.

Should have made this clear good ser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants