chore!: Remove add_file and file_reader from FileManager#3762
chore!: Remove add_file and file_reader from FileManager#3762kevaundray merged 6 commits intokw/make-fm-read-onlyfrom
add_file and file_reader from FileManager#3762Conversation
add_file from FileManager
add_file from FileManageradd_file and file_reader from FileManager
…path is canonical and the other which adds the root and canonicalizes (#3763) # Description ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
jfecher
left a comment
There was a problem hiding this comment.
What is the reasoning for this change?
This is a follow-up to #3760 -- I made it a separate PR just so that I could modularise the changes being made, but its intended to be merged into 3760 and then 3760 can be seen as one PR. This PR essentially removes |
This is a follow-up to #3760 -- I made it a separate PR just so that I could modularise the changes being made, but its intended to be merged into 3760 and then 3760 can be seen as one PR. This PR essentially removes
Should have made this clear good ser |
Description
This removes FileManager from add_file and uses add_file_with_source
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.