Skip to content

chore: try using two methods for adding files; one which assumes the path is canonical and the other which adds the root and canonicalizes#3763

Merged
kevaundray merged 3 commits intokw/remove-add-file-fmfrom
kw/diff-api-canonical-paths
Dec 11, 2023
Merged

chore: try using two methods for adding files; one which assumes the path is canonical and the other which adds the root and canonicalizes#3763
kevaundray merged 3 commits intokw/remove-add-file-fmfrom
kw/diff-api-canonical-paths

Conversation

@kevaundray
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

This essentially allows us to not special case the stdlib in the FileManager

@kevaundray kevaundray marked this pull request as ready for review December 11, 2023 15:30
@kevaundray kevaundray merged commit 1e2d4e4 into kw/remove-add-file-fm Dec 11, 2023
@kevaundray kevaundray deleted the kw/diff-api-canonical-paths branch December 11, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant