Skip to content

chore: Move tooling related items into their own directory#2644

Merged
kevaundray merged 6 commits intomasterfrom
kw/tooling-refactor
Sep 11, 2023
Merged

chore: Move tooling related items into their own directory#2644
kevaundray merged 6 commits intomasterfrom
kw/tooling-refactor

Conversation

@kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Sep 11, 2023

Description

This separates crates that are solely for tooling and crates that are for the compiler

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
Copy link
Contributor Author

nix build -L .#noirc_abi_wasm does not produce a node_modules folder locally -- Investigating if this was just getting cached before this change

@kevaundray
Copy link
Contributor Author

Added yarn install before testing and abi tests are now passing -- not sure how this was passing before then

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll follow up with some more modifications but this should get most of the rugging out of the way.

We'll need to update aztec-packages to pull the ACIR artifacts from their new location.

@kevaundray kevaundray added this pull request to the merge queue Sep 11, 2023
Merged via the queue into master with commit bc53432 Sep 11, 2023
@kevaundray kevaundray deleted the kw/tooling-refactor branch September 11, 2023 22:15
TomAFrench added a commit that referenced this pull request Sep 11, 2023
* master:
  chore: Move tooling related items into their own directory (#2644)
  chore: add `CompilationResult` helper type (#2639)
TomAFrench added a commit that referenced this pull request Sep 11, 2023
* master:
  chore: Move tooling related items into their own directory (#2644)
  chore: add `CompilationResult` helper type (#2639)
  fix: initialise arrays returned by brillig (#2048)
  chore: clippy fix (#2631)
  fix(wasm): Remove stacker from dependencies (#2637)
TomAFrench added a commit that referenced this pull request Sep 11, 2023
* master:
  chore: Move tooling related items into their own directory (#2644)
  chore: add `CompilationResult` helper type (#2639)
  fix: initialise arrays returned by brillig (#2048)
  chore: clippy fix (#2631)
  fix(wasm): Remove stacker from dependencies (#2637)
  chore(ci): reenable CI for `noir_wasm` (#2636)
  fix: avoid overflows in integer division (#2180)
  chore(ci): Nightly Integration testing  (#2596)
  feat(parser): allow multiple attributes (#2537)
  feat(nargo): Allow installing custom backends from the CLI (#2632)
  chore(ci): enforce clippy and `cargo fmt` in CI (#2628)
TomAFrench added a commit that referenced this pull request Sep 11, 2023
* master:
  chore: Move tooling related items into their own directory (#2644)
  chore: add `CompilationResult` helper type (#2639)
  fix: initialise arrays returned by brillig (#2048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants