fix(wasm): Remove stacker from dependencies#2637
Merged
kevaundray merged 1 commit intomasterfrom Sep 11, 2023
Merged
Conversation
kevaundray
approved these changes
Sep 11, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 11, 2023
* master: chore: Move tooling related items into their own directory (#2644) chore: add `CompilationResult` helper type (#2639) fix: initialise arrays returned by brillig (#2048) chore: clippy fix (#2631) fix(wasm): Remove stacker from dependencies (#2637) chore(ci): reenable CI for `noir_wasm` (#2636) fix: avoid overflows in integer division (#2180) chore(ci): Nightly Integration testing (#2596) feat(parser): allow multiple attributes (#2537) feat(nargo): Allow installing custom backends from the CLI (#2632) chore(ci): enforce clippy and `cargo fmt` in CI (#2628)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Up until this change, we've been unable to build
noir_wasmon Mac. When trying to compile, we'd get this message:While the error was "Section too large", I felt like it might be a red herring since the
libpsm_s.awas mentioned in the warning. In the psm docs, it claims:I did some digging and found we were only getting the dependency due to default features of chumsky (the
spill-stackfeature), so I turned off the feature and tried for compiling to wasm—and it worked!I'm not exactly sure why
noir_wasmcompiles on Linux but not Mac with this dependency, but seems that it wouldn't be doing anything in the wasm context, so I'm also guessing we don't rely on it.@jfecher Do you know if Noir actively depend upon this
spill-stackfeature through thestackerdependency of chumsky?Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.