fix: Run `wasm` nodejs tests with no fails by dmvict · Pull Request #2387 · noir-lang/noir

dmvict · 2023-08-21T13:46:15Z

Description

Fix of testing process of crate wasm

Problem*

The nodejs tests of crate wasm fail because mocha cannot resolve some imports. Mocha throws error

TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for [filepath]

Summary*

The bug is fixed using alternative import and changed resolving of filepaths.

Documentation

I think the crate wasm should provide the documentation for building and testing processes.

Additional Context

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

kevaundray · 2023-08-21T17:36:54Z

Can you add a test:node command to the package.json?

dmvict · 2023-08-22T05:26:52Z

Hello @kevaundray

Can you add a test:node command to the package.json?

Yes, I will.

I have a few thoughts about changes. I will try to improve the PR.

…test_fix

dmvict · 2023-08-22T12:02:10Z

Hello @kevaundray
I've added the command and I've tested my ideas.

I have had two ideas how to make minimal changes. The minimal changes is the changed file index.test.ts and some command/config.
First idea is to setup alternative mocha options and compile the tests. I've tried many different combinations and each time tests was failed.
The second idea is to compile module using standard typescript compiler tsc and then run tests. It works as expected. To run the tests I need to execute two commands:

tsc tests/node/index.test.ts
npm test

The solution requires no additional dependencies and only change the commands in package.json:

+    "build:node": "tsc test/node/index.test.ts",
...
+    "test": "npm run build:node && env TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha",

The command npm test will save artifacts with .js extension. The artifacts can be cleaned after testing.

I think that the second solution is a bit better than the current realization. What do you think?

crates/wasm/test/shared.ts

kevaundray · 2023-08-22T12:15:59Z

Hello @kevaundray I've added the command and I've tested my ideas.

I have had two ideas how to make minimal changes. The minimal changes is the changed file index.test.ts and some command/config. First idea is to setup alternative mocha options and compile the tests. I've tried many different combinations and each time tests was failed. The second idea is to compile module using standard typescript compiler tsc and then run tests. It works as expected. To run the tests I need to execute two commands:
tsc tests/node/index.test.ts
npm test 
The solution requires no additional dependencies and only change the commands in package.json:
+    "build:node": "tsc test/node/index.test.ts",
...
+    "test": "npm run build:node && env TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha",
The command npm test will save artifacts with .js extension. The artifacts can be cleaned after testing.

I think that the second solution is a bit better than the current realization. What do you think?

Second option sounds better -- also this seems like the logical thing to do

dmvict · 2023-08-22T12:29:25Z

Second option sounds better -- also this seems like the logical thing to do

I will switch to the package and add types to it.

…e-resolver`, update type declaration

kevaundray · 2023-08-24T14:48:03Z

btw seems we are only testing browser here:

noir/.github/workflows/wasm.yml

Line 202 in 182d017

run: yarn test:browser

dmvict · 2023-08-25T11:23:26Z

btw seems we are only testing browser here:

noir/.github/workflows/wasm.yml

Line 202 in 182d017

run: yarn test:browser

I'm trying to keep PRs with minimal changes.

I've added the node testing in the commit.

* master: fix: Run `wasm` nodejs tests with no fails (#2387) chore: Run `cargo fmt` (#2455)

* master: feat(ssa): Reuse existing results for duplicated instructions with no side-effects (#2460) fix: Closure lvalue capture bugfix (#2457) feat: Syntax for environment types now works with generics (#2383) fix(parser): fixes for the parsing of 'where' clauses (#2430) fix: Run `wasm` nodejs tests with no fails (#2387)

Savio-Sou · 2023-08-30T03:28:13Z

Does this closes #2326?

cc @kobyhallx

dmvict · 2023-08-30T05:00:29Z

Does this closes #2326?

cc @kobyhallx

Hello @Savio-Sou

Since we have passed nodejs tests https://github.com/noir-lang/noir/actions/runs/6019172378/job/16328784396#step:8:3 we can close the issue.

* master: (42 commits) fix(ssa): Handle right shift with constants (#2481) chore(noir): Release 0.10.4 (#2354) fix: Divide by zero should fail to satisfy constraints for `Field` and ints (#2475) fix(ssa): Remove padding from ToRadix call with constant inputs (#2479) fix: Implement handling of array aliasing in the mem2reg optimization pass (#2463) chore: resolve `Instruction` inputs fully before checking against cache (#2472) chore: Move independent `run_test` function into nargo core (#2468) feat: Standard library functions can now be called with closure args (#2471) feat(frontend): aztec syntactic sugar (feature flagged) (#2403) chore(ci): enforce compliance with `cargo fmt` (#2467) chore(ci): Allow releases to have additional feature flags (#2405) feat: Add `assert_eq` keyword (#2137) fix(ssa): Do not optimize for allocates in constant folding (#2466) feat(ssa): Reuse existing results for duplicated instructions with no side-effects (#2460) fix: Closure lvalue capture bugfix (#2457) feat: Syntax for environment types now works with generics (#2383) fix(parser): fixes for the parsing of 'where' clauses (#2430) fix: Run `wasm` nodejs tests with no fails (#2387) chore: Run `cargo fmt` (#2455) chore: Perform formatting changes to integration tests (#2448) ...

dmvict changed the title ~~fix: Run mocha nodejs tests with no fails~~ fix: Run wasm nodejs tests with no fails Aug 21, 2023

fix: Run mocha nodejs tests with no fails

688bc98

dmvict force-pushed the wasm_test_fix branch from 6e71aea to 688bc98 Compare August 21, 2023 14:07

dmvict marked this pull request as draft August 22, 2023 05:29

dmvict added 2 commits August 22, 2023 13:41

Merge branch 'master' of https://github.com/noir-lang/noir into wasm_…

7898ab5

…test_fix

feat: Add command test:node to package.json of crate wasm

c0ef41c

TomAFrench reviewed Aug 22, 2023

View reviewed changes

crates/wasm/test/shared.ts Outdated Show resolved Hide resolved

dmvict mentioned this pull request Aug 22, 2023

feat: Add generation of types, fix tests noir-lang/noir-source-resolver#8

Merged

2 tasks

fix: Update file shared.ts to use new version of module `noir-sourc…

d5919a4

…e-resolver`, update type declaration

dmvict marked this pull request as ready for review August 22, 2023 13:26

dmvict requested a review from TomAFrench August 24, 2023 08:55

kevaundray closed this in noir-lang/noir-source-resolver#8 Aug 24, 2023

kevaundray reopened this Aug 24, 2023

dmvict added 2 commits August 24, 2023 17:48

chore: Update version of dependency in package.json of crate wasm

e45b7fe

feat: Update workflow wasm, add command to test node target

2cc5db5

kevaundray approved these changes Aug 26, 2023

View reviewed changes

kevaundray added this pull request to the merge queue Aug 28, 2023

Merged via the queue into noir-lang:master with commit 67b6710 Aug 28, 2023

kevaundray mentioned this pull request Aug 28, 2023

chore(noir): Release 0.10.4 #2354

Merged

TomAFrench added a commit that referenced this pull request Aug 28, 2023

Merge branch 'master' into deduplicate-instructions

b06cb16

* master: fix: Run `wasm` nodejs tests with no fails (#2387) chore: Run `cargo fmt` (#2455)

Savio-Sou linked an issue Aug 30, 2023 that may be closed by this pull request

Noir-wasm nodeJs testing #2326

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Run `wasm` nodejs tests with no fails#2387

fix: Run `wasm` nodejs tests with no fails#2387
kevaundray merged 6 commits intonoir-lang:masterfrom
dmvict:wasm_test_fix

dmvict commented Aug 21, 2023

Uh oh!

kevaundray commented Aug 21, 2023

Uh oh!

dmvict commented Aug 22, 2023

Uh oh!

dmvict commented Aug 22, 2023 •

edited

Loading

Uh oh!

Uh oh!

kevaundray commented Aug 22, 2023

Uh oh!

dmvict commented Aug 22, 2023

Uh oh!

kevaundray commented Aug 24, 2023

Uh oh!

dmvict commented Aug 25, 2023

Uh oh!

Savio-Sou commented Aug 30, 2023

Uh oh!

dmvict commented Aug 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dmvict commented Aug 21, 2023

Description

Problem*

Summary*

Documentation

Additional Context

PR Checklist*

Uh oh!

kevaundray commented Aug 21, 2023

Uh oh!

dmvict commented Aug 22, 2023

Uh oh!

dmvict commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kevaundray commented Aug 22, 2023

Uh oh!

dmvict commented Aug 22, 2023

Uh oh!

kevaundray commented Aug 24, 2023

Uh oh!

dmvict commented Aug 25, 2023

Uh oh!

Savio-Sou commented Aug 30, 2023

Uh oh!

dmvict commented Aug 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dmvict commented Aug 22, 2023 •

edited

Loading